search

spencerkimball / stargazers

Analyze GitHub stars
Apache License 2.0
496 stars 41 forks source link

fix logging and compile issues #6

Closed bassam closed 6 years ago

bassam commented 7 years ago

Fixed numerous compile issues with logging and errors. Also added strgazer_cache to .gitignore.

Addresses #5

bassam commented 7 years ago

@spencerkimball can you please take a quick look?

spencerkimball commented 7 years ago

@bassam thank you so much for these updates. I hate to ask, but is there any way you could just remove the dependency on CockroachDB entirely and just simplify by using Go's base log package?

bassam commented 7 years ago

@spencerkimball ha! I started there and should've checked with you first. ok no prob.

bassam commented 7 years ago

@spencerkimball note that we lose info, warn and error levels. you also lose color support I believe. do you care?

spencerkimball commented 7 years ago

No, logging for this isn't so busy those features are critical.

bassam commented 6 years ago

@spencerkimball final had a chance to update this. let me know if you have any issues with it.

spencerkimball commented 6 years ago

Awesome. Thank you! I'll merge it now.