using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
noticeable slowdown is observed with inputs above 10k characters
users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks
Patches
The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.
Workarounds
In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.
The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.
Release Notes
moment/moment (moment)
### [`v2.29.4`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2294)
[Compare Source](https://togithub.com/moment/moment/compare/2.29.3...2.29.4)
- Release Jul 6, 2022
- [#6015](https://togithub.com/moment/moment/pull/6015) \[bugfix] Fix ReDoS in preprocessRFC2822 regex
### [`v2.29.3`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2293-Full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.29.2...2.29.3)
- Release Apr 17, 2022
- [#5995](https://togithub.com/moment/moment/pull/5995) \[bugfix] Remove const usage
- [#5990](https://togithub.com/moment/moment/pull/5990) misc: fix advisory link
### [`v2.29.2`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2292-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.29.1...2.29.2)
- Release Apr 3 2022
Address https://github.com/moment/moment/security/advisories/GHSA-8hfj-j24r-96c4
### [`v2.29.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2291-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.29.0...2.29.1)
- Release Oct 6, 2020
Updated deprecation message, bugfix in hi locale
### [`v2.29.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2290-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.28.0...2.29.0)
- Release Sept 22, 2020
New locales (es-mx, bn-bd).
Minor bugfixes and locale improvements.
More tests.
Moment is in maintenance mode. Read more at this link:
https://momentjs.com/docs/#/-project-status/
### [`v2.28.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2280-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.27.0...2.28.0)
- Release Sept 13, 2020
Fix bug where .format() modifies original instance, and locale updates
### [`v2.27.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2270-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.26.0...2.27.0)
- Release June 18, 2020
Added Turkmen locale, other locale improvements, slight TypeScript fixes
### [`v2.26.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2260-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.25.3...2.26.0)
- Release May 19, 2020
TypeScript fixes and many locale improvements
### [`v2.25.3`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2253)
[Compare Source](https://togithub.com/moment/moment/compare/2.25.2...2.25.3)
- Release May 4, 2020
Remove package.json module property. It looks like webpack behaves differently
for modules loaded via module vs jsnext:main.
### [`v2.25.2`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2252)
[Compare Source](https://togithub.com/moment/moment/compare/2.25.1...2.25.2)
- Release May 4, 2020
This release includes ES Module bundled moment, separate from it's source code
under dist/ folder. This might alleviate issues with finding the \`./locale
subfolder for loading locales. This might also mean now webpack will bundle all
locales automatically, unless told otherwise.
### [`v2.25.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2251)
[Compare Source](https://togithub.com/moment/moment/compare/2.25.0...2.25.1)
- Release May 1, 2020
This is a quick patch release to address some of the issues raised after
releasing 2.25.0.
- [2e268635](https://togithub.com/moment/moment/commit/2e268635) \[misc] Revert [#5269](https://togithub.com/moment/moment/issues/5269) due to webpack warning
- [226799e1](https://togithub.com/moment/moment/commit/226799e1) \[locale] fil: Fix metadata comment
- [a83a521](https://togithub.com/moment/moment/commit/a83a521) \[bugfix] Fix typeoff usages
- [e324334](https://togithub.com/moment/moment/commit/e324334) \[pkg] Add ts3.1-typings in npm package
- [28cc23e](https://togithub.com/moment/moment/commit/28cc23e) \[misc] Remove deleted generated locale en-SG
### [`v2.25.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2250-See-full-changelog)
[Compare Source](https://togithub.com/moment/moment/compare/2.24.0...2.25.0)
- Release May 1, 2020
- [#4611](https://togithub.com/moment/moment/issues/4611) [022dc038](https://togithub.com/moment/moment/commit/022dc038) \[feature] Support for strict string parsing, fixes [#2469](https://togithub.com/moment/moment/issues/2469)
- [#4599](https://togithub.com/moment/moment/issues/4599) [4b615b9d](https://togithub.com/moment/moment/commit/4b615b9d) \[feature] Add support for eras in en and jp
- [#4296](https://togithub.com/moment/moment/issues/4296) [757d4ff8](https://togithub.com/moment/moment/commit/757d4ff8) \[feature] Accept custom relative thresholds in duration.humanize
- 18 bigfixes
- 36 locale fixes
- 5 new locales (oc-lnc, zh-mo, en-in, gom-deva, fil)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
[ ] If you want to rebase/retry this PR, check this box
This PR has been generated by Mend Renovate. View repository job log here.
This PR contains the following updates:
2.24.0->2.29.4GitHub Vulnerability Alerts
CVE-2022-31129
Impact
Patches
The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.
Workarounds
In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.
References
There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=
Details
The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing.
moment("(".repeat(500000))will take a few minutes to process, which is unacceptable.Release Notes
moment/moment (moment)
### [`v2.29.4`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2294) [Compare Source](https://togithub.com/moment/moment/compare/2.29.3...2.29.4) - Release Jul 6, 2022 - [#6015](https://togithub.com/moment/moment/pull/6015) \[bugfix] Fix ReDoS in preprocessRFC2822 regex ### [`v2.29.3`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2293-Full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.2...2.29.3) - Release Apr 17, 2022 - [#5995](https://togithub.com/moment/moment/pull/5995) \[bugfix] Remove const usage - [#5990](https://togithub.com/moment/moment/pull/5990) misc: fix advisory link ### [`v2.29.2`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2292-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.1...2.29.2) - Release Apr 3 2022 Address https://github.com/moment/moment/security/advisories/GHSA-8hfj-j24r-96c4 ### [`v2.29.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2291-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.0...2.29.1) - Release Oct 6, 2020 Updated deprecation message, bugfix in hi locale ### [`v2.29.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2290-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.28.0...2.29.0) - Release Sept 22, 2020 New locales (es-mx, bn-bd). Minor bugfixes and locale improvements. More tests. Moment is in maintenance mode. Read more at this link: https://momentjs.com/docs/#/-project-status/ ### [`v2.28.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2280-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.27.0...2.28.0) - Release Sept 13, 2020 Fix bug where .format() modifies original instance, and locale updates ### [`v2.27.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2270-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.26.0...2.27.0) - Release June 18, 2020 Added Turkmen locale, other locale improvements, slight TypeScript fixes ### [`v2.26.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2260-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.25.3...2.26.0) - Release May 19, 2020 TypeScript fixes and many locale improvements ### [`v2.25.3`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2253) [Compare Source](https://togithub.com/moment/moment/compare/2.25.2...2.25.3) - Release May 4, 2020 Remove package.json module property. It looks like webpack behaves differently for modules loaded via module vs jsnext:main. ### [`v2.25.2`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2252) [Compare Source](https://togithub.com/moment/moment/compare/2.25.1...2.25.2) - Release May 4, 2020 This release includes ES Module bundled moment, separate from it's source code under dist/ folder. This might alleviate issues with finding the \`./locale subfolder for loading locales. This might also mean now webpack will bundle all locales automatically, unless told otherwise. ### [`v2.25.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2251) [Compare Source](https://togithub.com/moment/moment/compare/2.25.0...2.25.1) - Release May 1, 2020 This is a quick patch release to address some of the issues raised after releasing 2.25.0. - [2e268635](https://togithub.com/moment/moment/commit/2e268635) \[misc] Revert [#5269](https://togithub.com/moment/moment/issues/5269) due to webpack warning - [226799e1](https://togithub.com/moment/moment/commit/226799e1) \[locale] fil: Fix metadata comment - [a83a521](https://togithub.com/moment/moment/commit/a83a521) \[bugfix] Fix typeoff usages - [e324334](https://togithub.com/moment/moment/commit/e324334) \[pkg] Add ts3.1-typings in npm package - [28cc23e](https://togithub.com/moment/moment/commit/28cc23e) \[misc] Remove deleted generated locale en-SG ### [`v2.25.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2250-See-full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.24.0...2.25.0) - Release May 1, 2020 - [#4611](https://togithub.com/moment/moment/issues/4611) [022dc038](https://togithub.com/moment/moment/commit/022dc038) \[feature] Support for strict string parsing, fixes [#2469](https://togithub.com/moment/moment/issues/2469) - [#4599](https://togithub.com/moment/moment/issues/4599) [4b615b9d](https://togithub.com/moment/moment/commit/4b615b9d) \[feature] Add support for eras in en and jp - [#4296](https://togithub.com/moment/moment/issues/4296) [757d4ff8](https://togithub.com/moment/moment/commit/757d4ff8) \[feature] Accept custom relative thresholds in duration.humanize - 18 bigfixes - 36 locale fixes - 5 new locales (oc-lnc, zh-mo, en-in, gom-deva, fil)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.