spencermountain / compromise

modest natural-language processing
http://compromise.cool
MIT License
11.31k stars 645 forks source link

Fix for some switch lock-ins for common terms #1078

Closed ryancasburn-KAI closed 5 months ago

ryancasburn-KAI commented 5 months ago

About

(Part of #1074)

The word "about" no longer is an afterWords switch for all switches utilizing _adj. It is still used for adj-past switches though.

Also

Fixes #1070

If "also" is the term previous in the sentence, use the next most previous term (if one exists), for the tests.

I'm sure there are edge cases being missed and other "lock-in" terms which may be causing issues. But I wanted to get this in before you publish the next release to take care of these more simple issues.

How does this look? I'm worried this might break certain sentences or phrases that we aren't testing for.

spencermountain commented 5 months ago

perfect. I'll finish these last 8 failing tests, and do a release today. thank you!