Update naming of 'day' unit to 'date'. Fixes #296.

spencermountain / spacetime

A lightweight javascript timezone library

http://spacetime.how/

Other

3.98k stars 184 forks source link

Update naming of 'day' unit to 'date'. Fixes #296. #297

Closed coatesap closed 3 years ago

coatesap commented 3 years ago

I initially assumed this bug was down to a more complex issue around DST changes, but it turned out to be caused just by a naming inconsistency between day and date.

I'm not sure what the history of "date" vs "day" for the unit name is, but certainly in terms of intervals, "day" does make more sense, and I can see why the code that caused this bug looked correct.

spencermountain commented 3 years ago

ah thanks! nice idea.

coatesap commented 3 years ago

@spencermountain No worries - could you tag a new minor version so we can update our dependency?

spencermountain commented 3 years ago

released as v6.16.3 - thanks Andy!