Closed joshball closed 2 years ago
Hey Josh! Great idea. Pr welcomed!
would a simple change to this solve the issue?
this.silent = options.silent ?? true
That is what I use in modern-diacritics as both current node versions as well as all modern browsers now support the ??
operator (more info: Nullish coalescing operator (??) on MDN)
yep! that sounds good to me. thanks
I cannot trigger an Ambiguity Warning by setting the
silent
option tofalse
It looks like there is some faulty logic in constructor:
That is strange logic to parse as written as
options.silent
is passed in as false according to the README:I guess a few possible fixes:
Add a new method:
Then something like this:
Or something equally as confusing:
And of course, add a test or two.