search

spencermountain / spacetime

A lightweight javascript timezone library
http://spacetime.how/
Other
3.98k stars 184 forks source link

Beesley/i18n #325

Closed mbbzrc closed 2 years ago

mbbzrc commented 2 years ago

Hoping to contribute as a follow-up to issue #145 regarding hard-coded strings. I followed the existing pattern used to internationalize the months and days and added an ampm.js file to update the 'am' and 'pm' strings if passed in to i18n. I also updated the i18n test and the README.

Note: certain languages may need more complex options depending on time of day.

Any feedback is very welcome. Thanks!

spencermountain commented 2 years ago

this is a really clever solution. Thank you Anthony!