spencermountain / spacetime

A lightweight javascript timezone library
http://spacetime.how/
Other
3.97k stars 184 forks source link

Remove this if statement #370

Closed vbv-shm closed 1 year ago

vbv-shm commented 1 year ago

This if statement prevents the string "years" to come after the age. This commit removes it and the unit "year" is added with age.

spencermountain commented 1 year ago

hey Vaibhav - just getting to this - would you like me to merge this? happy to improve this file, in any way. cheers

vbv-shm commented 1 year ago

Hi Spencer, I am new and noob in the software world. Please verify that merging won't cause any issues.

spencermountain commented 1 year ago

welcome! yeah, i think the idea was that it would only print the unit if it wasn't years:

npx space-age june 8 1992 
// 30
npx space-age june 8 1992 --months
// 368 (months)

good pr! think this is intended behaviour though. cheers

vbv-shm commented 1 year ago

Thank you.