search

spencermountain / spacetime

A lightweight javascript timezone library
http://spacetime.how/
Other
3.97k stars 184 forks source link

fix types resolution for node16 / bundler #393

Closed meowtec closed 11 months ago

meowtec commented 11 months ago

If nodeResolution in tsconfig.json is set to Node16 NodeNext or Bundler, TypeScript (tested on version 5.1.6) will throw error:

import spacetime from 'spacetime';
'spacetime' is declared but its value is never read.ts(6133)
Could not find a declaration file for module 'spacetime'.
jecraig commented 11 months ago

Looks to work correctly for Node16 and continues to run with the older Node setting.

Fixes https://github.com/spencermountain/spacetime/issues/356 Thanks

spencermountain commented 11 months ago

thank you! I'll release this tomorrow morning. cheers

spencermountain commented 11 months ago

released as 7.4.5 👌