Closed zhibek closed 11 months ago
Whoaaaaa! Busy tomorrow, but will look at this first thing Wednesday. Thank you for letting me know.
hey John, this is fixed now in 10.1.7 - thanks for the heads-up. someone put a 15-thousand-line geojson blob in the wikivoyage markup, using a deprecated template. Maybe there's a clever fix, but I've just ignored the maplink xml template, for now. cheers
Thanks @spencermountain. Seeing your PR, I understand the library better now. If I see any similar issues in the future I'll aim to contribute a PR to fix.
FYI, confirming your fix looks good to me. The following URLs are now processed without crashing (or very slow parsing):
Processing some Wikivoyage pages results in an out of memory crash. Example URL: https://en.wikivoyage.org/wiki/Interstate_5
Minimal example:
Results in error:
Tested on a laptop with 16GB RAM running Ubuntu 22.04 / Node 16.20.2.