spencernah / pe

0 stars 0 forks source link

When undoing commands, the action of "list command" is not reverted #10

Open spencernah opened 2 years ago

spencernah commented 2 years ago

Undo should also apply to filter-related commands like "list".

Commands sequence executed: find Spencer list undo

After executing the 3rd command (undo), the app should display the filtered contact list (i.e. execute "find" command). However, app does not do this currently - it display all contact (result of the 2nd command (list))

nus-pe-script commented 2 years ago

Team's Response

The undo command will only undo commands that modify the actual contact list, e.g. edit, delete, add and clear

list filter are just for display. For example, in MicroSoft Word, you won't expect to be able to undo if you go to View and turn on ruler or zoom at different level.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: If that is the case then this should be explicitly mentioned in the UG, similar to how it states that it does not support the rename command. UG should also briefly mention that it is used to undo commands that modify contacts. With the current details offered, users will assume that it can be used to undo all commands except rename.

image.png


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]