spencernah / pe

0 stars 0 forks source link

When batch editing multiple contacts, error message does not update after executing a valid command #9

Open spencernah opened 2 years ago

spencernah commented 2 years ago

This may be confusing for the users as they will be unsure if the valid command has been processed.

Command sequence executed: edit -batch 23, 24 n/Spencer edit -batch 23, 24 p/1111

After submitting the 2nd command (valid), observe that the error message is unchanged (still displaying "invalid command format!" that is triggered by the first invalid command).

edit-batch_multiple_error-message.png

nus-pe-bot commented 2 years ago

Team's Response

The second one is also an invalid command.

There should not be no space in between the INDEX.

e.g. edit -batch 23,24 p/1111

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In this case, the error message should update accordingly to prompt the users that there cannot be any space between the indexes. Instead, the error message remained as "Contact cannot have the same name" which does not clearly describe what the issue is.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Affects the usability of the application. Users are unsure of the mistakes that they are making and the application does not provide guidance to correct their mistakes.