Closed 0atman closed 2 months ago
I don't think I agree with this change for a few reasons:
Philosophical: users of Miniflux don't think of using Miniflux by visiting the api's URL, but by visiting the URL of their running Miniflux instance. The most obvious "what URL are they asking me for here" is "the one in the address bar when I have the Miniflux web UI open".
Forward-compatible: In the event that there's ever a /v2/
API for Miniflux, I want cliflux to be able to choose to use it only when we know the code is compatible, rather than having users put "whatever the highest number is" in this config field, and then being puzzled at why cliflux is broken.
Backward-compatible: I dunno how many people use this little personal project I wrote, but it seems like the answer is "more than just me" (which is still a pleasant surprise for me!). Implementing this change would be a breaking change, that would require existing users to read release notes to learn why their cliflux
app isn't working, and then make changes to their existing config file. That's a cost to existing users, and so it should have a clear benefit. I don't think this shift is a clear benefit in that regard.
That said, if this is a clearer mental model for you, I'm not offended by your use of a personal fork.
Very fine points! Thank you again :smile:
Problem
I don't know if I'm right here - but I was confused that
miniflux.app
has/v1/
already appended to the API Endpoint when you make an api key:But writing that into
~/.config/cliflux/config.toml
causes this error in cliflux:note
/v1/v1/
in the formatted url.What this PR does to fix it
/v1/
s in the 3 places in the code it's referenced.Bonuses
rust-toolchain
file set tostable
, as there are some wild issues with https://github.com/tkaitchuck/aHash/issues/200 that can be sidestepped by building on stable. I'm not sure if this is helpful, let me know if I should remove it from this PR.Rationale
This of course could easily be fixed by removing
/v1/
in the config file when you paste in your base_url, but I think the assumption is wrong:base_url
should be the API base, not the bare domain, I think?Thank you!