Excel to xml - Githubissues

spences10 / VBA-IDE-Code-Export

Export & Import VBA code for use with Git (or any VCS)

MIT License

119 stars 34 forks source link

Excel to xml #69

Closed spences10 closed 7 years ago

spences10 commented 7 years ago

Resolves #57

@mattpalermo review and merge pls sir :tophat:

mattpalermo commented 7 years ago

Nice work @spences10. Looks like a good start to the XL<->XML feature set.

I'll try to test it soon. Have you tested this out and got it working yourself? I am skeptical about the use of "ThisWorkbook" instead of "ActiveWorkbook", but maybe I'm just confused.

I have a lot of thoughts about refinements, and will submit them as a review soon. Would you like to merge as soon as possible and refine it later or deal with refinements before merge?

spences10 commented 7 years ago

HoLeeShit @mattpalermo!!

Ok, they're all valid points, some of them I find a bit hard to understand what you want changing due to the GitHub interface

It was a first attempt just to get something up there working, I've done a bit more work on it

mattpalermo commented 7 years ago

Sorry haha. I got a bit carried away. As I mentioned though, there are only two really critical issues, the rest are simply things that I think would improve the quality of the code.

spences10 commented 7 years ago

Hey, thanks just submitted 916a66f30fe7319ec0c08ff1f8c8de869f1d88e6

mattpalermo commented 7 years ago

It is good work though :+1: you've figured out the hard bits.

spences10 commented 7 years ago

@mattpalermo tried to answer most of your points raised mate.

Just to recap where we are with this now:

Unpack will unpack the ActiveWorkbook schoolboy error on my part!
Tydy the code so variables are not needlessly created

What I haven't covered:

The CodeExport.config.json file hasn't been updated appropriately. The new module and the new reference needs to be added to it.

^^ is this just hardcode in the config??

mattpalermo commented 7 years ago

Yea, I am mostly just concerned with the CodeExport.config.json file. It can be either hand crafted or generated with the Make Config File button. Checkout my recent README file changes. That might shed some light on the purpose of keeping the CodeExport.config.json file updated.

spences10 commented 7 years ago

mattpalermo commented 7 years ago

@spences10 facepalm haha. I love those badges! And I'm starting the think you might love badges as well 🤔

spences10 commented 7 years ago

Yes my friend!!

Get those AGD all over the place!!