search

spences10 / vscode-vba

VBA syntax highlighting and snippets for use in VSCode
MIT License
56 stars 30 forks source link

Updated property / Class specifiics in the DocumentSymbolProvider & Snippets #15

Closed jaunito76 closed 3 years ago

jaunito76 commented 4 years ago

Recommend accepting the changes in the DocumentSymbolProvider, the snippets are a bit more for use in my coding projects, but I think that they would be useful to many users so I included them in the pull request. I am happy to discuss, I have been searching for a way to make this better with a language provider, but I think that might be a bit beyond my time and capability at this point. Let me know what you think

CJ

spences10 commented 4 years ago

Hi, thanks for your PR

bit more for use in my coding projects, but I think that they would be useful to many users

If this is for your coding projects then it may be of benefit to you to fork the repo and make your own extension.

If you can give an explanation as to why this would be useful to many users that would be great.

Currently I don't see what this is adding for other users.

And yeah, we all want that language provider magic too

jaunito76 commented 4 years ago

What I added is support for classes within vba, in the current version you do not have property included in the syntax highlighting.

spences10 commented 3 years ago

Sorry, had to close this as I haven't time to go through the changes and don't feel that you gave a good enough explanation as to why you've added several new files what they're there for etc.

Thanks

jaunito76 commented 3 years ago

Sounds good, just a reminder that you don’t have the ‘Property (Get|Set|Let)’ as a keyword in the main branch version. My pull request had that fix in it, I did add to the vba.json in the snippets, but that is not that important, but the rest would make it easier to use.

-CJ

From: Scott Spence notifications@github.com Sent: Thursday, January 21, 2021 1:58 AM To: spences10/vscode-vba vscode-vba@noreply.github.com Cc: CJ Boris clinton.kliethermes@gmail.com; Author author@noreply.github.com Subject: Re: [spences10/vscode-vba] Updated property / Class specifiics in the DocumentSymbolProvider & Snippets (#15)

Sorry, had to close this as I haven't time to go through the changes and don't feel that you gave a good enough explanation as to why you've added several new files what they're there for etc.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spences10/vscode-vba/pull/15#issuecomment-764453749 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AIAIYI7CAJ57ZFYS274SKBLS27NBNANCNFSM4SRMMD4Q .

spences10 commented 3 years ago

I'll happily accept a PR with that on it 🙏

Also, @jaunito76 have you seen Excel Live Server?