search

spences10 / vscode-vba

VBA syntax highlighting and snippets for use in VSCode
MIT License
56 stars 30 forks source link

Support for 'Const' and 'Static' variables #4

Closed scottmwyant closed 5 years ago

scottmwyant commented 6 years ago

Add formatting support for constants and static variables. Make these other types of "variables" get the same formatting as the 'Dim' keyword. Note that I did not update any version numbers. Also, the diff on GitHub is showing a little funny. Line 102 is moved down to line 132 (added 'Static' keyword).

spences10 commented 6 years ago

Thanks for this @scottmwyant I'll take a look when I'm next push a version :ok_hand:

spences10 commented 6 years ago

@scottmwyant have you tested this?

scottmwyant commented 6 years ago

@spences10 Yes, I have this edit in my local version of the file. Also, you might want to add a Option Compare Text| after |Option Explicit| on line 132. I'm in the habit of setting those two options as the first two lines of a module. Best, - SW

spences10 commented 6 years ago

Great, can I pull the changes from your branch?

scottmwyant commented 6 years ago

Yes. I committed the bit about option compare text after last night. You should be able to merge.

spences10 commented 6 years ago

Ok, great, much appreciated @scottmwyant

I'm going to have to take a look at getting the extension onto the marketplace again, I have no recollection of how to do it 🙃

Apologies I'm going to have to keep it open until I move it to the marketplace, if I merge it now I'll forget and it'll never be done - hope you understand 🙏

spences10 commented 6 years ago

Hey @scottmwyant could you pull the latest changes and add your to this PR please?

Apologies I should have merged your changes first 🙃