spencewood / google-code-prettify

http://google-code-prettify.googlecode.com/
Apache License 2.0
89 stars 20 forks source link

Please publish an official NPM package #9

Open dtaylor113 opened 8 years ago

dtaylor113 commented 8 years ago

Hi, We use google-code-prettify as a dependency in our PatternFly toolkit (patternfly.org), however some of our consumers only use NPM to install PatternFly, so they currently can not get the google-code-prettify dependency since there isn't currently an official published NPM package for google-code-prettify

We are planning on publishing an NPM for google-code-prettify, but it would be ideal if there was an official NPM.

Thanks, Dave Taylor

wheelerlaw commented 8 years ago

It exists: https://www.npmjs.com/package/google-code-prettify

emeraldjava commented 7 years ago

I think if a team is using a maven build, the jar files are loaded from

http://www.webjars.org/npm

The google-code-prettify doesn't appear in the npm area here. It does in the bower area.

emeraldjava commented 7 years ago

@dtaylor113 Is there a workaround to exclude the 'google-code-prettify' from the patternfly build or load the jar file from a different maven repo?

emeraldjava commented 7 years ago

It seems there is some missing metadata in the package.json which means webjars can't publish the artifact. https://github.com/webjars/webjars/issues/1551

wheelerlaw commented 7 years ago

Well, the package.json is looking pretty bare if you ask me:

{
    "name": "google-code-prettify",
    "version": "1.0.5",
    "dependencies": {}
}
emeraldjava commented 7 years ago

I've posted a pull request https://github.com/spencewood/google-code-prettify/pull/14 which adds the required license details to the module.

emeraldjava commented 7 years ago

@dtaylor113 I've forked the project and added the Apache 2.0 which ensures npm webjars should have a v1.0.5 version in a few hours.

GroupID = org.webjars.npm ArtifactID = github-com-emeraldjava-google-code-prettify Version = 1.0.5

Can you test if patternfly will build if you update to reference this version?