public read permissions not set

spenczar / lektor-s3

Plugin to deploy a Lektor project to an S3 bucket

MIT License

44 stars 10 forks source link

public read permissions not set #5

Closed krosaen closed 8 years ago

krosaen commented 8 years ago

Is it just me or are the files not uploaded with public read permissions?

extra_args={'ACL': 'public-read'}

may do the trick (per docs)?

In the meantime, I manually updated the permissions after deploying.

spenczar commented 8 years ago

The readme mentions briefly that it expects the bucket to be set up with correct permissions ahead of time. This includes setting the bucket policy to allow reads on all objects.

I don't want lektor-s3 to get in the business of managing S3 buckets and their configuration, so I'll make the readme a little louder on this topic. Does that sound fair, @krosaen?

krosaen commented 8 years ago

Yes, completely fair, thanks for the heads up, and sorry for the failure-to-RTFM bug report :)