search

spendnetwork / silvereye

OCDS Data Review Tool
https://ocds-data-review-tool.readthedocs.io
Other
4 stars 3 forks source link

Autoenv deprecated in favour of direnv #38

Open benvand opened 4 years ago

benvand commented 4 years ago

The .env file installation workflow in the README.md will only work if a user has autoenv installed.

https://stackoverflow.com/a/9578590/3967444

The above stackoverflow q and a from Kennith Reitz states that autoenv is deprecated in favour of direnv.

I'd personally prefer not bothering to obfuscate these settings behind either autoenv or direnv because I think it makes the install process harder to understand and debug. I think theres value in telling users that these environment variables need to be present and what they do.

Just my 2 cents though.

If you want I'm happy to put together a PR removing the dependency on autoenv and updating the docs.

benvand commented 4 years ago

Also autoenv and direnv make me a bit uneasy in terms of having 'unpredictable' behaviours in the eyes of the uninitiated.

Ie 'Why does just changing directory make this work??'