search

spendright / msd

Merge SpendRight scraper data
Apache License 2.0
0 stars 1 forks source link

complex priorities for caps in brand names #47

Open coyotemarin opened 8 years ago

coyotemarin commented 8 years ago

We currently have a rule to discourage choosing ALL-CAPS brands, but for many brands, that's the correct capitalization (e.g. ASUS). Should walk this back.

Should also prefer a company name that matches the (all-caps) brand (which might sometimes be tricky).

coyotemarin commented 8 years ago

Basically, we want iPhone > IPhone > IPHONE > Iphone > iphone. This is pretty tricky; basically we prefer letters inside a word to be capitalized and initial letters to be lowercase, but we'd rather have some internal letters capitalized than all of them.

For now, I think this can be mostly fixed by fixing #40 (match flagship brand capitalization to company).