spenserblack / github-stats-rs

A tool for using Github's API
Apache License 2.0
1 stars 5 forks source link

Update user fields #18

Closed frjol closed 4 years ago

frjol commented 4 years ago

13 Update user fields

Please note htlm_url was changed to url since htlm_url is not part of the owner fields

spenserblack commented 4 years ago

There's actually an html_url value for bother repo and repo owner. See part of JSON response for this repo's API request.

{
  "id": 212819882,
  "node_id": "MDEwOlJlcG9zaXRvcnkyMTI4MTk4ODI=",
  "name": "github-stats-rs",
  "full_name": "spenserblack/github-stats-rs",
  "private": false,
  "owner": {
    "login": "spenserblack",
    "id": 8546709,
    "node_id": "MDQ6VXNlcjg1NDY3MDk=",
    "avatar_url": "https://avatars2.githubusercontent.com/u/8546709?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/spenserblack",
    "html_url": "https://github.com/spenserblack", <- here
    "followers_url": "https://api.github.com/users/spenserblack/followers",
    "following_url": "https://api.github.com/users/spenserblack/following{/other_user}",
    "gists_url": "https://api.github.com/users/spenserblack/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/spenserblack/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/spenserblack/subscriptions",
    "organizations_url": "https://api.github.com/users/spenserblack/orgs",
    "repos_url": "https://api.github.com/users/spenserblack/repos",
    "events_url": "https://api.github.com/users/spenserblack/events{/privacy}",
    "received_events_url": "https://api.github.com/users/spenserblack/received_events",
    "type": "User",
    "site_admin": false
  },
  "html_url": "https://github.com/spenserblack/github-stats-rs", <- and here
  "description": "A tool to get stats from Github",
frjol commented 4 years ago

Perfect. I'll put it back.

spenserblack commented 4 years ago

Great, thanks! All that's left is to change site_admin's return type from &bool to bool, and this PR is ready to be merged.