When required values are None, a request will still be attempted. It would be preferable if the user could be informed that the required values are missing before a request is made, wasting the user's time.
This should only be possible if the user runs Search::default(), so this could alternatively be fixed by removing implementation of Default (this would make the Option<String>s unnecessary, too, since they could just be Strings).
spenserblack
commented
5 years ago
See TODO in
search.rsforfn search.When required values are
None, a request will still be attempted. It would be preferable if the user could be informed that the required values are missing before a request is made, wasting the user's time.This should only be possible if the user runs
Search::default(), so this could alternatively be fixed by removing implementation ofDefault(this would make theOption<String>s unnecessary, too, since they could just beStrings).