search

speps / go-hashids

Go (golang) implementation of http://www.hashids.org
MIT License
1.32k stars 109 forks source link

Fix EncodeHex and DecodeHex from original implementations #51

Open mashmooli opened 5 years ago

mashmooli commented 5 years ago

Hi in original implementation encode the hex 5a74d76ac89b05000e977baa with salt this is my salt is equal with bv89jEY45DslgBOeD2Qg. but i tested it with this repo and it's different with original implementation. i fixed it in this PR.

bbsbb commented 5 years ago

What is the status of this? Is it going to be merged or not? Also, if it gets merged, how is it going to be released, seeing that it breaks backward compatibility?

ghost commented 5 years ago

I propose to close this issue.

vtolstov commented 4 years ago

why not release never version with go mod as /v2 ?

dolmen commented 4 years ago

Well, I think that a /v3 (v2.0.0 is already tagged) would have a lighter API and drop EncodeHex and DecodeHex.

In addition, this "fixed" implementation of DecodeHex use a regexp, which is not efficient, so it must not be merged as is.