Closed MrNaif2018 closed 1 year ago
@SomberNight @ecdsa Could you please review and/or merge my pr? Thanks in advance.
there are links to a third party project: bitcartcc.com
It shown it in the irc and feedback was fine. We can discuss it more in the irc but it is basically just a wrapper around electrums. It is opensource project too, and it just simplifies this process. Electrum has some backwards-incompatible changes and this project provides backwards-compatible API not depending on backwards-incompatible electrum changes.. I can remove .com links and leave onlly github link if needed.
Would love to use this in our products (starting with our PoC site, gzrograviteers.org). Electrum has proven to be a stable product that offers easy payments via electrumx. This PR offers a well documented interface, which I think will greatly improve opportunities for electrum integration.
I have viewed and contributed to bitcart code and didn't find any security vulnerabilities. This PR is very useful for many people. Some people don't have the resources to run full nodes, and they use electrum wallet to view their funds. If they see this doc page they could have their projects and electrum wallet always in sync.
I haven't known that electrum has such functionality! It would help me to reuse it in my projects! Such docs updates are very important for many people to discover something without asking in IRC every time the same things. As I see, in this third-party project you're discussing there are only 390 lines mostly, and I see no bitcoin-stealing malware in it.
@ecdsa I have removed third-party links + added where to find latest reference about creating Commands object (quick_start.py script)
This pull request explains electrum code structure, especially how CLI and RPC commands are generated, and how to run it directly from python. Also a ready solution for that is written here(discussed in IRC).