spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.35k stars 3.06k forks source link

stdio/text GUIs suffering from code rot #2354

Open twopir opened 7 years ago

twopir commented 7 years ago

I don't have a GUI installed on my Bitcoin machine (FreeBSD 9.3, Python 2.7.13, Electrum 2.8.2 downloaded as of today), so I rely on the stdio/text interfaces to Electrum.

These interfaces have multiple issues

twopir commented 7 years ago

With the stdio UI, storing a payment order works fine. Sending it does not:

Traceback (most recent call last):
  File "./electrum", line 379, in <module>
    d.init_gui(config, plugins)
  File "/usr/home/pi/Electrum-2.8.2/lib/daemon.py", line 283, in init_gui
    self.gui.main()
  File "/usr/home/pi/Electrum-2.8.2/gui/stdio.py", line 163, in main
    while self.done == 0: self.main_command()
  File "/usr/home/pi/Electrum-2.8.2/gui/stdio.py", line 65, in main_command
    elif c == "s" : self.send_order()
  File "/usr/home/pi/Electrum-2.8.2/gui/stdio.py", line 147, in send_order
    self.do_send()
  File "/usr/home/pi/Electrum-2.8.2/gui/stdio.py", line 180, in do_send
    if self.wallet.use_encryption:
AttributeError: 'Standard_Wallet' object has no attribute 'use_encryption'

Entering Unicode into the Curses UI generates similar M-BM-BLAH BLAH barf as to the Receive window.

I can use the Curses UI to send a payment, though.

SomberNight commented 6 years ago

Some of the mentioned issues should be fixed on master now, namely at least