search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.45k stars 3.09k forks source link

[segwit] different txid? #2904

Closed lzsaver closed 7 years ago

lzsaver commented 7 years ago

Electrum 3.0 master branch git 77eb62b

Electrum shows different txid before and after I sign my segwit transaction. The first one is the right one, all blockexplorers show it, but what is the second one? It seems not okay for segwit.

SomberNight commented 7 years ago

Can you give more details? (e.g. what type of wallet and keystore) On testnet, I created a "segwit" Standard_Wallet with a BIP32_KeyStore, and tried to send a 1 in 2 out tx (with input and both outputs controlled by the wallet). I couldn't reproduce the issue.

ecdsa commented 7 years ago

that's a bug, txid should not change. please give details

lzsaver commented 7 years ago

It is the standard wallet with the hardware trezor keystore, the derivation is m/49'/0'/0'.

Electrum shows only the wrong one in the UI. But it writes the right one to the wallet file.

ecdsa commented 7 years ago

are you sure you were on 77eb62b4cb580f1bd6b1e47d7aece0a46f0aa05e, and not on an earlier commit?

lzsaver commented 7 years ago

Yes, I'm sure.

ecdsa commented 7 years ago

ok, I see the issue. the txid is wrong in the tx details window, after the tx has been broadcast

lzsaver commented 7 years ago

That's right. Also this issue appears if I copy my signed tx and load it from the text without broadcasting it.

ecdsa commented 7 years ago

fixed in ab2d0f389c939adf0d89b8ec39b22132c0aeff3e