search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.39k stars 3.08k forks source link

OS X build: Size remains same after running package.sh #4834

Closed ghost closed 5 years ago

ghost commented 5 years ago

OS X build: Size remains same after running package.sh. The size before and after packaging is 90MB.

How to reduce dmg size?

Thanks.

ghost commented 5 years ago

Package.sh log

root@vinnyvoo:/home/electrum# ./contrib/build-osx/package.sh ~/Electrum.app 
genisoimage 1.1.11 (Linux)
usage: dmg [extract|build|iso|dmg] <in> <out> (-k <key>) (partition)
3.2.3-322-xxxxxxxx
genisoimage-1.1.11: Warning: assuming PC Exchange cluster size of 512 bytes
 10.83% done, estimate finish Fri Nov  7 12:59:37 2018
 21.67% done, estimate finish Fri Nov  7 12:59:37 2018
 32.47% done, estimate finish Fri Nov  7 12:59:37 2018
 43.30% done, estimate finish Fri Nov  7 12:59:37 2018
 54.10% done, estimate finish Fri Nov  7 12:59:37 2018
 64.94% done, estimate finish Fri Nov  7 12:59:37 2018
 75.74% done, estimate finish Fri Nov  7 12:59:37 2018
 86.57% done, estimate finish Fri Nov  7 12:59:37 2018
 97.37% done, estimate finish Fri Nov  7 12:59:37 2018
Total translation table size: 0
Total rockridge attributes bytes: 1532
Total directory bytes: 10608
Path table size(bytes): 96
Max brk space used 21000
46221 extents written (90 MB)
Processing DDM...
No DDM! Just doing one huge blkx then...
run 0: sectors=512, left=184884
run 1: sectors=512, left=184372
[REDACTED]
run 358: sectors=512, left=1588
run 359: sectors=512, left=1076
run 360: sectors=512, left=564
run 361: sectors=52, left=52
Writing XML data...
Generating UDIF metadata...
Master checksum: 4844cd12
Writing out UDIF resource file...
Cleaning up...
Done
Done.
<md5checksum>  electrum-3.2.3-322-xxxxxxxxx.dmg
SomberNight commented 5 years ago

Is this related to https://github.com/spesmilo/electrum/issues/4815 ? Can you try building the two commits mentioned in https://github.com/spesmilo/electrum/issues/4815#issuecomment-435119317 and see if there is a noticeable binary size difference?

ghost commented 5 years ago

Still the same size with current and this (e7fa42ce3ecef126d5e34fec206ec85173122d1b) commit. Thank you.

cculianu commented 5 years ago

See this commit on Electron Cash. We fixed it with some 'manual' removals of big fat binaries that pyinstaller was pulling in from Qt that were unneeded:

https://github.com/Electron-Cash/Electron-Cash/commit/4b0996959420dfca3d53f178d86205616d8c568b

cculianu commented 5 years ago

@SomberNight yes, it's related to #4815 I believe. Pyinstaller is pulling in the world when really it just needs a small province. :)