search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.47k stars 3.1k forks source link

Android Fiat Currency "Some currency not existing as desktop". #5157

Closed kpstar closed 1 month ago

kpstar commented 5 years ago

Desktop has all currencies in setting/Fiat Currency with history options. But android doesn't have some currencies because history option is set True by default.

I am about to use 'COP' currency but can't find in android. How can I use? Thanks.

SomberNight commented 5 years ago

But android doesn't have some currencies because history option is set True by default.

Yes, you are correct.

What exactly is the suggestion? To allow toggling the history option like in Qt?

kpstar commented 5 years ago

screenshot_28

kpstar commented 5 years ago

Thanks for your reply, @SomberNight I tried to change like this as attached image and installed my phone. It seemed there was no error regarding this action. I am just wondering why you disable history option.

I am also a mobile developer and want to contribute to your project. I wish you would give me some opinions. Thanks.

SomberNight commented 5 years ago

In Kivy, on the "Balance" tab, if you tap your balance at the top, all the values change between BTC and fiat. This is only possible with historical conversion rates. Thus, for simplicity, only currency/exchange combos that offer historical rates can be selected.

kpstar commented 5 years ago

Isn't there any way for all currencies in android?

kpstar commented 5 years ago

For example, setting checkbox for history option like desktop. Because I use 'COP' currency and mobile is essential.

SomberNight commented 5 years ago

You could add the same "show fiat history rates" option to settings like in Qt, enabled by default.

Feel free to make a pull request after testing.

accumulator commented 1 month ago

qml client uses FX like desktop, closing.