spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.44k stars 3.09k forks source link

Archos Safe T cosigners broken in multisig wallets #5446

Open passio777x opened 5 years ago

passio777x commented 5 years ago

Hi, I am training to use Multisig Electrum wallet. I created a 2/3 cosign wallet. 2 usual Wallet (we call them Wallet-1 and Wallet-2 here) in electrum and 1x Harware wallet with Archos Safe-T. (We cal them Wallet-Hardware) All last version are installed.

Firstly, I restore my Wallet-1 with the Wallet-1 seed + 2 Master Primary Key (W-2 and WH)

I tried to send some bitcoin to Wallet-3 with hat Wallet-1.

After I signed the transaction with this Wallet 1, I can't send the transaction to cosigner through Pool, I got message :

Failed to send transaction to cosigning pool: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:777)

I saw on internet, that it will probably always be impossible to share cosigning transaction if one of the cosigner is an Hardware Wallet (not sure I properly understand, my English is not perfect).

Then... I tried MANUAL Method...

I exported COSIGN.txn file from Wallet-1 (1/2 sign).

I connect on Hardware Wallet, open COSIGN.txn file... Put my digit code. Click on confirm and confirm again on Archos Safe-T.. I see signing progress bar... All seems ok. But, at the end, the TXN file still display 1/2 sign...

Then, I tried to send some bitcoin directly from this Wallet-Hardware account, same problem happen, status still be "UNSIGNED" when I try sign with the Archos Safe-T Mini.

To sum-up, it's impossible to sign with Archos Safe-T Mini through electrum.

passio777x commented 5 years ago

UP

SomberNight commented 5 years ago

I cannot yet reproduce.

What version of Electrum? Is it 3.3.6 (latest)? What type of multisig? 2-of-3, ok, but is it legacy or p2sh-segwit or native-segwit? How many outputs are there in the transaction you tried to make? Is there change?

Also, what is the firmware version on the Archos Safe-T Mini?

passio777x commented 5 years ago

I am not sure it answer to the question. I do not understand properly différence beetween segwit, legacy, etc… I selected all default options in Electrum to create my 3 wallets test when I created them. Maybe there is some compatibility to respect that I don’t know… What I can tell you if I log on my Multisig Wallet. When I click on Wallet -> information I see :

Script type : p2wsh

These are my 3 public Master key if that allow you to get any interresting informations... Zpub75w92TaL9F8jGbtPvyFwcEZztNUiAG3Xrx2cmraUFxrVomyCvgpseieq47btWvf29ka23qw7sRphbUdZiPVhYccu7xoTYUVYfBsSo5hLEjT Zpub6xnRpfKdjWPT95kn4v5MorLHSAaoLJaoQnKRcmawqPLnKiRmQ2HBLenjZt2VQZ4sWh76gxdqR29MfuLcPWe2bDTRxEzLvgJpQhM4cV7ziWz Zpub6z1AiKkcRJMPWDF68HbPTQwFh2t4vkNKUVeQCUuXAx63uTQWutHPjDQsydauyTwcxx9RqqTtrkoWxxciGqjMfc8V3tpkQSJvnWLXLHiNmmf

However, actually, I opened new ticket. Due to this first problem, I bought an old EeePc and installed Lubuntu. After I downloaded the Lubuntu driver for Safe-T from safe-t.io, I reloaded safe-t.io http://safe-t.io/ but my wallet was not detected. Same with Electrum. I though it was Lubuntu problem but when I tried to make it work later on iMac, my iMac was also not able to detect the Safe-T. I also tried with my Macbook, not detected.

The Safe-T is like bricked… However, I didn’t unplugged it while an update (that has been done the day before). I don’t know how it happened. When I plug it, I just see my cosmos Wallpaper… I can also long press on left button and got message to lock it. I can’t do more. It seems not possible to Reset the Safe-T without use a computer…

Le 25 juin 2019 à 18:35, ghost43 notifications@github.com a écrit :

I cannot yet reproduce.

What version of Electrum? Is it 3.3.6 (latest)? What type of multisig? 2-of-3, ok, but is it legacy or p2sh-segwit or native-segwit? How many outputs are there in the transaction you tried to make? Is there change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZJ6GQIGWEEGR3LSLDDP4JCLZA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQ2XXI#issuecomment-505523165, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZJFVFNHCNLO4EB5R2LP4JCLZANCNFSM4H2YTKYQ.

passio777x commented 5 years ago

Hi, I got no answer...

Le 25 juin 2019 à 20:25, Quentin Castelain kentinousss@gmail.com a écrit :

I am not sure it answer to the question. I do not understand properly différence beetween segwit, legacy, etc… I selected all default options in Electrum to create my 3 wallets test when I created them. Maybe there is some compatibility to respect that I don’t know… What I can tell you if I log on my Multisig Wallet. When I click on Wallet -> information I see :

Script type : p2wsh

These are my 3 public Master key if that allow you to get any interresting informations... Zpub75w92TaL9F8jGbtPvyFwcEZztNUiAG3Xrx2cmraUFxrVomyCvgpseieq47btWvf29ka23qw7sRphbUdZiPVhYccu7xoTYUVYfBsSo5hLEjT Zpub6xnRpfKdjWPT95kn4v5MorLHSAaoLJaoQnKRcmawqPLnKiRmQ2HBLenjZt2VQZ4sWh76gxdqR29MfuLcPWe2bDTRxEzLvgJpQhM4cV7ziWz Zpub6z1AiKkcRJMPWDF68HbPTQwFh2t4vkNKUVeQCUuXAx63uTQWutHPjDQsydauyTwcxx9RqqTtrkoWxxciGqjMfc8V3tpkQSJvnWLXLHiNmmf

However, actually, I opened new ticket. Due to this first problem, I bought an old EeePc and installed Lubuntu. After I downloaded the Lubuntu driver for Safe-T from safe-t.io http://safe-t.io/, I reloaded safe-t.io http://safe-t.io/ but my wallet was not detected. Same with Electrum. I though it was Lubuntu problem but when I tried to make it work later on iMac, my iMac was also not able to detect the Safe-T. I also tried with my Macbook, not detected.

The Safe-T is like bricked… However, I didn’t unplugged it while an update (that has been done the day before). I don’t know how it happened. When I plug it, I just see my cosmos Wallpaper… I can also long press on left button and got message to lock it. I can’t do more. It seems not possible to Reset the Safe-T without use a computer…

Le 25 juin 2019 à 18:35, ghost43 <notifications@github.com mailto:notifications@github.com> a écrit :

I cannot yet reproduce.

What version of Electrum? Is it 3.3.6 (latest)? What type of multisig? 2-of-3, ok, but is it legacy or p2sh-segwit or native-segwit? How many outputs are there in the transaction you tried to make? Is there change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZJ6GQIGWEEGR3LSLDDP4JCLZA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQ2XXI#issuecomment-505523165, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZJFVFNHCNLO4EB5R2LP4JCLZANCNFSM4H2YTKYQ.

passio777x commented 5 years ago

Hi... Today, i tried to use Ubuntu (Lubuntu)... I reset my archos safe T... I created a new seed... I STILL HAVE SAME ISSUE. I can't SIGN with my Archos Safe-T..... I even can't get back my mBitcoin...

passio777x commented 5 years ago

I just uploaded a Youtube video, hope you will be able to help. 1 month and still not have solution, same issue on Mac OS and Ubuntu. VIDEO : Electrum and Archos Safe-T - Can't sign multisig

passio777x commented 5 years ago

UP . . .

SomberNight commented 5 years ago

As I had said, I could not reproduce your original issue when signing with an Archos Safe T.

You seem to be implying that your bitcoins are locked. However this is a 2 of 3 multisig wallet, and only one of the cosigners is a Safe T? So you can just sign a transactions with the other two cosigners and spend your coins. Alternatively, you can also restore from seed, with the seed of the Safe T cosigner, and effectively convert that to a software signer. Or you can buy another hardware wallet device, from a different manufacturer, and restore from seed words on that device.

SomberNight commented 5 years ago

What is the firmware version on your Archos Safe T?

SomberNight commented 5 years ago

The Safe-T is like bricked… However, I didn’t unplugged it while an update (that has been done the day before). I don’t know how it happened. When I plug it, I just see my cosmos Wallpaper… I can also long press on left button and got message to lock it. I can’t do more. It seems not possible to Reset the Safe-T without use a computer…

I just uploaded a Youtube video, hope you will be able to help.

I have now followed along and replicated the same steps that are visible in your video, and I cannot reproduce the problem. I only get the same behaviour if I cancel signing on the hardware device (but it works if I choose to confirm). This suggests that indeed your specific hardware might be faulty.

I have firmware version 1.0.5. This is visible if you click the Safe T icon in the bottom right of the main Electrum window.

passio777x commented 5 years ago

I am on iMac 2018, you think this hardware could be faulty? Then you recommend me to use an other device right ?

Le 19 juil. 2019 à 01:56, ghost43 notifications@github.com a écrit :

The Safe-T is like bricked… However, I didn’t unplugged it while an update (that has been done the day before). I don’t know how it happened. When I plug it, I just see my cosmos Wallpaper… I can also long press on left button and got message to lock it. I can’t do more. It seems not possible to Reset the Safe-T without use a computer…

I just uploaded a Youtube video, hope you will be able to help.

I have now followed along and replicated the same steps that are visible in your video, and I cannot reproduce the problem. I only get the same behaviour if I cancel signing on the hardware device (but it works if I choose to confirm). This suggests that indeed your specific hardware might be faulty.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZMDCSAHBKPS7SKUCJDQAD7K7A5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KFG3A#issuecomment-513037164, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZPFVQJGQB7GMRDQ5VLQAD7K7ANCNFSM4H2YTKYQ.

SomberNight commented 5 years ago

I only get the same behaviour if I cancel signing on the hardware device (but it works if I choose to confirm). This suggests that indeed your specific hardware might be faulty.

I am on iMac 2018, you think this hardware could be faulty? Then you recommend me to use an other device right ?

I meant the Archos Safe T, not your desktop computer.

passio777x commented 5 years ago

My normal wallet is Segwit and the Archos is Native segwit multisig (p2wsh) Is it the same for you ?

I am not sure it is the Safe-T because I changed it and still have same issue. I crashed my first Archos Safe-T after to many tries on modified Linux

Le 19 juil. 2019 à 01:59, ghost43 notifications@github.com a écrit :

I only get the same behaviour if I cancel signing on the hardware device (but it works if I choose to confirm). This suggests that indeed your specific hardware might be faulty.

I am on iMac 2018, you think this hardware could be faulty? Then you recommend me to use an other device right ?

I meant that Archos Safe T, not your desktop computer.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZLXMJMTH3DKG5DQVULQAD7VJA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KFLUI#issuecomment-513037777, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZJX6QSH6TSTYLR5EWTQAD7VJANCNFSM4H2YTKYQ.

SomberNight commented 5 years ago

My normal wallet is Segwit and the Archos is Native segwit multisig (p2wsh) Is it the same for you ?

Yes, everything that is visible on your video, I have tried to replicate. (though I was testing on Linux not Mac; it should not matter)

What is the firmware version on your Archos Safe T?

passio777x commented 5 years ago

And, if I try to send for cosign, I got error message :

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:777)

Same issue from linux or Mac

Le 19 juil. 2019 à 02:22, Quentin Castelain kentinousss@gmail.com a écrit :

<Capture d’écran 2019-07-19 à 02.22.10.png>

Le 19 juil. 2019 à 02:20, ghost43 <notifications@github.com mailto:notifications@github.com> a écrit :

My normal wallet is Segwit and the Archos is Native segwit multisig (p2wsh) Is it the same for you ?

Yes, everything that is visible on your video, I have tried to replicate. (though I was testing on Linux not Mac; it should not matter)

What is the firmware version on your Archos Safe T?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZJCOMAPGQPXY7P42HTQAECGDA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KGLHY#issuecomment-513041823, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZNKZ6TV4CGBTOVTXO3QAECGDANCNFSM4H2YTKYQ.

SomberNight commented 5 years ago

Try to enable debug logging and reproduce the signing issue; then upload logs here.

And, if I try to send for cosign, I got error message :

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:777)

That's a separate issue; unrelated to the signing.

passio777x commented 5 years ago

I am actually looking for the directory where are the logs :

After restarting Electrum, debug logs will be written to the /logs folder inside the :ref:datadir <datadir> https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#id7.

Le 19 juil. 2019 à 02:26, ghost43 notifications@github.com a écrit :

Try to enable debug logging https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#how-to-enable-debug-logging and reproduce the signing issue; then upload logs here.

And, if I try to send for cosign, I got error message :

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:777)

That's a separate issue; unrelated to the signing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZK7AAKKKJAPKHX7P73QAECZVA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KGSUA#issuecomment-513042768, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZLLXF3IS6HOPHKQ243QAECZVANCNFSM4H2YTKYQ.

SomberNight commented 5 years ago

See https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#where-is-the-electrum-datadir-located

passio777x commented 5 years ago

This is the log file, thank you very much !

Le 19 juil. 2019 à 02:34, ghost43 notifications@github.com a écrit :

See https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#where-is-the-electrum-datadir-located https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#where-is-the-electrum-datadir-located — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZK274XAIRD4D5BROYLQAEDZ7A5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KHAKY#issuecomment-513044523, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZKRHVE5KWWC62GBNFDQAEDZ7ANCNFSM4H2YTKYQ.

passio777x commented 5 years ago

Do you need I delete the log file and make the 2 error and send you again the log file ?

Le 19 juil. 2019 à 02:37, Quentin Castelain kentinousss@gmail.com a écrit :

This is the log file, thank you very much !

> Le 19 juil. 2019 à 02:34, ghost43 > a écrit : > > See https://github.com/spesmilo/electrum-docs/blob/master/faq.rst#where-is-the-electrum-datadir-located > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub , or mute the thread . >
SomberNight commented 5 years ago

Just reproduce the signing error, and then upload the latest logfile here.

passio777x commented 5 years ago

It looks better. I didn’t know there was many .log file created sorry.

Le 19 juil. 2019 à 02:41, ghost43 notifications@github.com a écrit :

SomberNight commented 5 years ago

Oh I see you are trying to attach the logfile to the email you are using to reply. I think that will not work on GitHub. You need to come to the site and use the interface to attach the file. Or you can upload / paste it elsewhere, and just include a link.

passio777x commented 5 years ago

I joined now the log file on last reply on this post where I tried to get help : https://github.com/spesmilo/electrum/issues/5516 https://github.com/spesmilo/electrum/issues/5516 Confirm if it’s ok for you.

Le 19 juil. 2019 à 02:52, ghost43 notifications@github.com a écrit :

Oh I see you are trying to attach the logfile to the email you are using to reply. I think that will not work on GitHub. You need to come to the site and use the interface to attach the file. Or you can upload / paste it elsewhere, and just include a link.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZKMJGQGDCINWWHMTT3QAEF3FA5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KHW7I#issuecomment-513047421, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZPBUCJOHMRA7XXVIP3QAEF3FANCNFSM4H2YTKYQ.

SomberNight commented 5 years ago

I can see the log, yes. However that only shows the cosigner pool issue. That is unrelated to the main problem you have, which is that apparently you cannot sign with the Archos Safe T device. Please upload a log that shows you trying to sign with that.

passio777x commented 5 years ago

https://github.com/spesmilo/electrum/issues/5516 https://github.com/spesmilo/electrum/issues/5516

I uploaded it too

Le 19 juil. 2019 à 03:06, ghost43 notifications@github.com a écrit :

I can see the log, yes. However that only shows the cosigner pool issue. That is unrelated to the main problem you have, which is that apparently you cannot sign with the Archos Safe T device. Please upload a log that shows you trying to sign with that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZMHTTUEHLE5IFFIW2LQAEHS7A5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KIKAI#issuecomment-513049857, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZJBUFKPSXMB3NPRHYLQAEHS7ANCNFSM4H2YTKYQ.

passio777x commented 5 years ago

(I made 2 try in this log file).

Le 19 juil. 2019 à 03:06, ghost43 notifications@github.com a écrit :

I can see the log, yes. However that only shows the cosigner pool issue. That is unrelated to the main problem you have, which is that apparently you cannot sign with the Archos Safe T device. Please upload a log that shows you trying to sign with that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spesmilo/electrum/issues/5446?email_source=notifications&email_token=AKNODZMHTTUEHLE5IFFIW2LQAEHS7A5CNFSM4H2YTKY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KIKAI#issuecomment-513049857, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNODZJBUFKPSXMB3NPRHYLQAEHS7ANCNFSM4H2YTKYQ.

passio777x commented 5 years ago

I just realized this talk was upload in Github.

SomberNight commented 5 years ago

From the new log I can tell that the software seed is signing successfully and adding one signature; the missing signature is the one that should be added by the Safe T. The log looks identical to what I get when I cancel the tx signing on the hardware device. If you are correctly operating the hardware device and confirming the transaction to be signed using its physical buttons, then the issue is definitely with the Safe T.

I have already asked numerous times: what is the firmware version on your Archos Safe T?

passio777x commented 5 years ago

Sorry, I uploaded you a picture in Mails, ignoring they were not uploaded here. I confirm the software seed add the signing successfully yes, I can See 1/2 with that.

Capture d’écran 2019-07-19 à 02 22 10
passio777x commented 5 years ago

I uploaded a video about what I see on my Hardware wallet Safe-T... https://youtu.be/_G0lqvb1ORY

passio777x commented 5 years ago

4:17AM here, wake up 8:30AM... Need to sleep now... I Hope a miracle...

SomberNight commented 5 years ago

Ok, I have reproduced the bug on firmware version 1.1.3 (latest). The issue was NOT present with firmware version 1.0.5 which is what I was testing with before. This is clearly a bug in the new firmware, and thus not up to Electrum to fix.

AFAICT the Archos Safe T mini with fw 1.1.3 is unusable in multisig wallets as cosigner (neither derivation path, nor script type seem to matter). It still functions in single-signer (standard) wallets. An easier way to see that something is wrong is testing the "show address" functionality. The Safe T with fw 1.1.3 is showing an incorrect address on the device screen.

@jcrona

passio777x commented 5 years ago

Congratulation... I am happy to get confirmation that II was not the problem. What am I supposed to do now ?

SomberNight commented 5 years ago

Hopefully Archos releases a new firmware that fixes the issue.

Until then, I have already enumerated some workarounds above:

You seem to be implying that your bitcoins are locked. However this is a 2 of 3 multisig wallet, and only one of the cosigners is a Safe T? So you can just sign a transactions with the other two cosigners and spend your coins. Alternatively, you can also restore from seed, with the seed of the Safe T cosigner, and effectively convert that to a software signer. Or you can buy another hardware wallet device, from a different manufacturer, and restore from seed words on that device.

passio777x commented 5 years ago

It's no more à 2/3 but a 2/2 now. Because I tried again. Hopefully it's only 0.01 mBtc.

Are you really telling me I can convert my 24 word recovery Safe-T to an usual electrum wallet ?

Do you know when the Archos Firmware will be updated ?

passio777x commented 5 years ago

I finally received the fund (due to low fees). When I try to send them back, this si new log error : electrum_log_20190720T124504Z_8314.log

With error displayed : The server returned an error when broadcasting the transaction. Consider trying to connect to a different server, or updating Electrum.

Transaction could not be broadcast due to dust outputs.

jcrona commented 5 years ago

@SomberNight Thx for narrowing down the issue to the Safe-T mini ! @passio777x We (Archos) are going to look into it, and try to fix it asap for the next firmware release. Thanks for highlighting the issue !

passio777x commented 5 years ago

Hi, please update firmware or Refund.

passio777x commented 5 years ago

Hi, please update Firmware or refund...