spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.35k stars 3.06k forks source link

AttributeError: 'ElectrumWindow' object has no attribute 'payto_URI' #5639

Closed TARS-bot closed 4 years ago

TARS-bot commented 5 years ago

Crash Report

This crash report was reported through the automatic crash reporting system 🤖

Traceback

  File "/home/philippe/.local/lib/python3.6/site-packages/electrum/gui/qt/main_window.py", line 1718, in do_preview
    self.do_pay(preview=True)
  File "/home/philippe/.local/lib/python3.6/site-packages/electrum/gui/qt/main_window.py", line 1721, in do_pay
    invoice = self.read_invoice()
  File "/home/philippe/.local/lib/python3.6/site-packages/electrum/gui/qt/main_window.py", line 1707, in read_invoice
    return self.wallet.create_invoice(outputs, message, self.payment_request, self.payto_URI)

AttributeError: 'ElectrumWindow' object has no attribute 'payto_URI'

Reporter

This issue was reported by 3 user(s):

Electrum Version Python Version Operating System Wallet Type Locale Stack
3.3.8 3.6.8 (default, Aug 20 2019, 17:12:48) [GCC 8.3.0] Linux-5.0.0-27-generic-x86_64-with-Ubuntu-18.04-bionic standard fr_FR ℹ
3.3.8-1136-g1773bd6c 3.6.8 (default, Apr 9 2019, 04:59:38) [GCC 8.3.0] Linux-4.18.0-25-generic-x86_64-with-Ubuntu-18.10-cosmic standard en_IN ℹ
3.3.8 3.7.3 (default, Oct 7 2019, 12:56:13) [GCC 8.3.0] Linux-5.0.0-38-generic-x86_64-with-Ubuntu-19.04-disco standard en_US ℹ

Additional Information

I am using a Ledger on testnet

$ electrum --testnet E | plugins.trezor.trezor | error importing trezorlib Traceback (most recent call last): File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/plugins/trezor/trezor.py", line 24, in import trezorlib ModuleNotFoundError: No module named 'trezorlib' W | gui.qt.installwizard.InstallWizard | error getting device infos for coldcard: Missing libraries for coldcard. // Make sure you install it with python3 W | gui.qt.installwizard.InstallWizard | error getting device infos for keepkey: Missing libraries for keepkey. // Make sure you install it with python3 W | gui.qt.installwizard.InstallWizard | error getting device infos for safe_t: Missing libraries for safe_t. // Make sure you install it with python3 W | gui.qt.installwizard.InstallWizard | error getting device infos for trezor: Missing libraries for trezor. // Make sure you install it with python3 qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205 qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205 qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205 qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205 E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter Traceback (most recent call last): File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/gui/qt/main_window.py", line 1721, in do_pay invoice = self.read_invoice() File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/gui/qt/main_window.py", line 1707, in read_invoice return self.wallet.create_invoice(outputs, message, self.payment_request, self.payto_URI) AttributeError: 'ElectrumWindow' object has no attribute 'payto_URI'


SomberNight commented 5 years ago

fixed in https://github.com/spesmilo/electrum/commit/0b87ce426f1bb2e4debf6810f7ec362d23a14af4

Thanks for testing git master! :)

TARS-bot commented 4 years ago

Good morning @SomberNight,

I just received another crash report related to this issue. The crash occured on Electrum 3.3.8-1136-g1773bd6c. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 3.3.8 since you closed the issue.

Could you please check if this issue really is resolved? Here is the traceback that I just collected:

  File "/home/akash/electrum/electrum/gui/qt/main_window.py", line 1708, in do_save_invoice
    invoice = self.read_invoice()
  File "/home/akash/electrum/electrum/gui/qt/main_window.py", line 1700, in read_invoice
    return self.wallet.lnworker.parse_bech32_invoice(self.payto_e.lightning_invoice)

AttributeError: 'NoneType' object has no attribute 'parse_bech32_invoice'

~ With robotic wishes

lacksfish commented 4 years ago

This is still occurring. I'm using a Ledger device if that matters. The error occurs after hitting "SEND" to send a transaction.

Attached are the error logs. This is with Ledger 3.3.8

$ electrum --testnet
E | plugins.trezor.trezor | error importing trezorlib
Traceback (most recent call last):
  File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/plugins/trezor/trezor.py", line 24, in <module>
    import trezorlib
ModuleNotFoundError: No module named 'trezorlib'
W | gui.qt.installwizard.InstallWizard | error getting device infos for coldcard: Missing libraries for coldcard. // Make sure you install it with python3
W | gui.qt.installwizard.InstallWizard | error getting device infos for keepkey: Missing libraries for keepkey. // Make sure you install it with python3
W | gui.qt.installwizard.InstallWizard | error getting device infos for safe_t: Missing libraries for safe_t. // Make sure you install it with python3
W | gui.qt.installwizard.InstallWizard | error getting device infos for trezor: Missing libraries for trezor. // Make sure you install it with python3
qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205
qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205
qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205
qt.svg: /usr/share/icons/Faba/16x16/actions/dialog-ok.svg:112: Could not resolve property: linearGradient4205
E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
  File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/gui/qt/main_window.py", line 1721, in do_pay
    invoice = self.read_invoice()
  File "/home/lacksfish/.local/lib/python3.7/site-packages/electrum/gui/qt/main_window.py", line 1707, in read_invoice
    return self.wallet.create_invoice(outputs, message, self.payment_request, self.payto_URI)
AttributeError: 'ElectrumWindow' object has no attribute 'payto_URI'
SomberNight commented 4 years ago

@lacksfish What commit are you on? These lines are not present in the 3.3.8 release. The issue is already fixed in latest master.