Open TARS-bot opened 5 years ago
E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
File "...\electrum\electrum\gui\qt\channel_details.py", line 103, in do_ln_payment_completed
self.move('inflight', 'settled', payment_hash)
File "...\electrum\electrum\gui\qt\channel_details.py", line 75, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: [... some RHASH here ...]
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.0b1. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.0a0 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "/home/pv/Desktop/1/Electrum-4.0.0b1/electrum/gui/qt/channel_details.py", line 109, in do_ln_payment_completed
self.move('inflight', 'settled', payment_hash)
File "/home/pv/Desktop/1/Electrum-4.0.0b1/electrum/gui/qt/channel_details.py", line 79, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b"\xb1n\xd3Oj\xd2i'\xc7\x16\xea=F\xedx\xf2t\xc5o\xa3\xc4\x9c\xb3\xe5\xcfC\x16\xb3XL\xa40"
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.1. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.0b1 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "electrum\gui\qt\channel_details.py", line 109, in do_ln_payment_completed
File "electrum\gui\qt\channel_details.py", line 79, in move
KeyError: b'\x08\x89\xa0\x11R=9\x07\xa8\x87\x80f\xe0\xae\x0b\xa5\xd5,\xc7\xc6\xc8\xfc\xdc\xae\x9a\xf5\x1c\xa1\x08\xef\xf0\xfa'
~ With robotic wishes
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.2. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.1 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "electrum/gui/qt/channel_details.py", line 109, in do_ln_payment_completed
File "electrum/gui/qt/channel_details.py", line 79, in move
KeyError: b'~ \x0c\xa7\xbd\xe8\xcb\xfe\x1d`\x03b\x1f}\xa3\nH>\xf98\x97\x01\xc8z\xe3g^\xd3\xeby\xef\xde'
~ With robotic wishes
Good afternoon @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.3. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.2 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "electrum\gui\qt\channel_details.py", line 109, in do_ln_payment_completed
File "electrum\gui\qt\channel_details.py", line 79, in move
KeyError: b'\x83}VQ\xfc\xc3\xea\xf1\x0cGm6v\x13V\xaa\xf33\xf8\x9a\x1ax\x82\xb0\xdeB\x88\xede\x05\xf6\xfd'
~ With robotic wishes
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.4. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.3 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "/tmp/.mount_electrBlc5pZ/usr/lib/python3.7/site-packages/electrum/gui/qt/channel_details.py", line 116, in do_ln_payment_failed
self.move('inflight', 'failed', payment_hash)
File "/tmp/.mount_electrBlc5pZ/usr/lib/python3.7/site-packages/electrum/gui/qt/channel_details.py", line 79, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b'\xb9f\xbd`\x1e\xa2\xec}\x1doq\xa4C\x0c\xe8\x1bF\xc0\xbe\xe8gm\xed>\xfa\xa2\xd5\xea\x01M\x91\x0f'
~ With robotic wishes
Good afternoon @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.5. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.4 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "electrum\gui\qt\channel_details.py", line 109, in do_ln_payment_completed
File "electrum\gui\qt\channel_details.py", line 79, in move
KeyError: b'\xcdU\xb8a\x17\x9c\x08\x8d\xa9&A\xd3\xfd0\xe2f\x0f{\xc3\xd0\x0b\xc5Dt\xfb\xcb\xc9\xa6\xcaz\xc4\xbc'
~ With robotic wishes
I can reproduce. it occurs when the channel details window has been open earlier, and is closed when the payment occurs
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.0.9. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.5 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "electrum\gui\qt\channel_details.py", line 109, in do_ln_payment_completed
File "electrum\gui\qt\channel_details.py", line 79, in move
KeyError: b'\xf8\xe8\xca\x9a\x86\x98\xc4\xd0\x1b\xe8j?9\xde\xebt\x0c\x8f\xfb\xa7\xc8\x83m\xeb5\xa0RY\x95\xb3\xe0\x0c'
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.1.2. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.0.9 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
File "/home/ondra/Electrum-4.1.2/electrum/gui/qt/channel_details.py", line 117, in on_htlc_failed
self.move('inflight', 'failed', payment_hash)
File "/home/ondra/Electrum-4.1.2/electrum/gui/qt/channel_details.py", line 80, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b'g\xe44\xbf\xd7j\xc0\x1cc\x02S\x18\xe7[\xca\xa5F\x13\xca\x7f\xe1\x18*\xf37\xc4q\xf6V<\x00#'
~ With robotic wishes
Good afternoon @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.1.5. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.1.2 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/home/ondra/.local/lib/python3.8/site-packages/electrum/gui/qt/channel_details.py", line 117, in on_htlc_failed
self.move('inflight', 'failed', payment_hash)
File "/home/ondra/.local/lib/python3.8/site-packages/electrum/gui/qt/channel_details.py", line 80, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b'\xaeC\x11\xbc\x8b\x7f\'\x06\xd3\xe1\xfc\xce\xeak\x05\x1e\x12T\x0c\xa4\xae"\xe9b0\x10\xb3V\xd9\xcc\xcd\xb7'
KeyError: b'\xaeC\x11\xbc\x8b\x7f\'\x06\xd3\xe1\xfc\xce\xeak\x05\x1e\x12T\x0c\xa4\xae"\xe9b0\x10\xb3V\xd9\xcc\xcd\xb7'
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.2.2. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.1.5 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "electrum/gui/qt/channel_details.py", line 117, in on_htlc_failed
File "electrum/gui/qt/channel_details.py", line 80, in move
KeyError: b"5\xa4\r-\x9d\xb2F\xb8'\xcb\x9b\xc2\xf7\xe1j\x13\xfd\xe3t.\x9d\x9f\n\xd2\x0e'\xdd\xd1`\xc3k\xd0"
KeyError: b"5\xa4\r-\x9d\xb2F\xb8'\xcb\x9b\xc2\xf7\xe1j\x13\xfd\xe3t.\x9d\x9f\n\xd2\x0e'\xdd\xd1`\xc3k\xd0"
~ With robotic wishes
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.3.2. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.2.2 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/tmp/.mount_electrZjaNiv/usr/lib/python3.9/site-packages/electrum/gui/qt/util.py", line 1669, in on_qt_callback_signal
return func(self, *args[1:])
File "/tmp/.mount_electrZjaNiv/usr/lib/python3.9/site-packages/electrum/gui/qt/channel_details.py", line 149, in on_event_htlc_fulfilled
self.move('inflight', 'settled', payment_hash)
File "/tmp/.mount_electrZjaNiv/usr/lib/python3.9/site-packages/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b'\xed\xd5y_\x8a*\xdf\xbb\xd3W\xe8\xf0;\x95Z\x1bY\xc1\x1c\xfe4{Hk/\x04\x16\xde\xb0\xac\x94j'
KeyError: b'\xed\xd5y_\x8a*\xdf\xbb\xd3W\xe8\xf0;\x95Z\x1bY\xc1\x1c\xfe4{Hk/\x04\x16\xde\xb0\xac\x94j'
~ With robotic wishes
Good afternoon @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.4.5. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.3.2 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/home/miernik/.local/pipx/venvs/electrum/lib/python3.11/site-packages/electrum/gui/qt/util.py", line 1283, in on_qt_callback_signal
return func(self, *args[1:])
^^^^^^^^^^^^^^^^^^^^^
File "/home/miernik/.local/pipx/venvs/electrum/lib/python3.11/site-packages/electrum/gui/qt/channel_details.py", line 156, in on_event_htlc_failed
self.move('inflight', 'failed', payment_hash)
File "/home/miernik/.local/pipx/venvs/electrum/lib/python3.11/site-packages/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: b'E\xc4\xa6Ra[\xc5\xaa\xdfE\x86R\xe4\x14H.Cl\x0b\x9ed\xe8\x97\x88\xe7\x8a|)\x986\x14\xe2'
KeyError: b'E\xc4\xa6Ra[\xc5\xaa\xdfE\x86R\xe4\x14H.Cl\x0b\x9ed\xe8\x97\x88\xe7\x8a|)\x986\x14\xe2'
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.5.0b1. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.4.5 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/electrum/electrum/gui/qt/util.py", line 1420, in on_qt_callback_signal
return func(self, *args[1:])
^^^^^^^^^^^^^^^^^^^^^
File "/electrum/electrum/gui/qt/channel_details.py", line 156, in on_event_htlc_failed
self.move('inflight', 'failed', payment_hash)
File "/electrum/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: b'\xd7rBM\xdb\x8c\xcf\x1a\xfdyQE\\<TiX\xd3\x08\x04\x08\xe5^\x96zE\xf7\xd1{\xc0\xed@'
KeyError: b'\xd7rBM\xdb\x8c\xcf\x1a\xfdyQE\\<TiX\xd3\x08\x04\x08\xe5^\x96zE\xf7\xd1{\xc0\xed@'
~ With robotic wishes
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.5.2. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.5.0b1 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/home/hannes/.local/lib/python3.10/site-packages/electrum/gui/qt/util.py", line 1426, in on_qt_callback_signal
return func(self, *args[1:])
File "/home/hannes/.local/lib/python3.10/site-packages/electrum/gui/qt/channel_details.py", line 149, in on_event_htlc_fulfilled
self.move('inflight', 'settled', payment_hash)
File "/home/hannes/.local/lib/python3.10/site-packages/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
KeyError: b'\x82v\xdb\x00r\x1c\xe9_v40i7\r<V8o\x0b\xf3\\II\x9c\x87\x92\xcb?\xd0\xb9\x80t'
KeyError: b'\x82v\xdb\x00r\x1c\xe9_v40i7\r<V8o\x0b\xf3\\II\x9c\x87\x92\xcb?\xd0\xb9\x80t'
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.5.3. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.5.2 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "electrum\gui\qt\util.py", line 1429, in on_qt_callback_signal
File "electrum\gui\qt\channel_details.py", line 149, in on_event_htlc_fulfilled
File "electrum\gui\qt\channel_details.py", line 126, in move
KeyError: b'\xab\x9f6\xc0b\xc5\xe3\x9d$U1sx\xdb\xe9O\x0c\xbe_\xe1v\xae\xb7 \x14NSw\x80}\xb1G'
KeyError: b'\xab\x9f6\xc0b\xc5\xe3\x9d$U1sx\xdb\xe9O\x0c\xbe_\xe1v\xae\xb7 \x14NSw\x80}\xb1G'
~ With robotic wishes
Although I cannot reproduce this, I think there is no guarantee that qt callbacks are going to be called in the right order.
This might result from on_event_htlc_fulfilled
being called before on_event_htlc_added
, which would explain the bug.
In addition, qt callbacks are not going to be called if the channel details window has not been instantiated.
Maybe a htlc_added
event might be received after create_htlc_list
has been called, but before the window is fully instantiated.
note: while investigating this issue, I noted that the channel details window does not update received HTLCs. this can be fixed by adding callbacks:
index bd94eedfa..bd3421a76 100644
--- a/electrum/lnpeer.py
+++ b/electrum/lnpeer.py
@@ -2204,6 +2204,8 @@ class Peer(Logger):
channel_id=chan.channel_id,
id=htlc_id,
payment_preimage=preimage)
+ payment_hash = sha256(preimage)
+ util.trigger_callback('htlc_fulfilled', payment_hash, chan, htlc_id)
def fail_htlc(self, *, chan: Channel, htlc_id: int, error_bytes: bytes):
self.logger.info(f"fail_htlc. chan {chan.short_channel_id}. htlc_id {htlc_id}.")
@@ -2216,6 +2218,8 @@ class Peer(Logger):
id=htlc_id,
len=len(error_bytes),
reason=error_bytes)
+ payment_hash = sha256(preimage)
+ util.trigger_callback('htlc_failed', payment_hash, chan, htlc_id)
def fail_malformed_htlc(self, *, chan: Channel, htlc_id: int, reason: OnionRoutingFailure):
self.logger.info(f"fail_malformed_htlc. chan {chan.short_channel_id}. htlc_id {htlc_id}.")
@@ -2230,6 +2234,8 @@ class Peer(Logger):
id=htlc_id,
sha256_of_onion=reason.data,
failure_code=reason.code)
+ payment_hash = sha256(preimage)
+ util.trigger_callback('htlc_failed', payment_hash, chan, htlc_id)
def on_revoke_and_ack(self, chan: Channel, payload):
if chan.peer_state == PeerState.BAD:
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.5.4. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.5.3 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "electrum\gui\qt\util.py", line 1429, in on_qt_callback_signal
File "electrum\gui\qt\channel_details.py", line 156, in on_event_htlc_failed
File "electrum\gui\qt\channel_details.py", line 126, in move
KeyError: b'[\x8er\\z\x86\x10 \x823\xf9\xf6\xeci\x1d\x07\xe5\xa9\xd9P80\xa1\xcf\xcfH\xb4\xaa\xd6{\xc3\xd4'
KeyError: b'[\x8er\\z\x86\x10 \x823\xf9\xf6\xeci\x1d\x07\xe5\xa9\xd9P80\xa1\xcf\xcfH\xb4\xaa\xd6{\xc3\xd4'
~ With robotic wishes
Good evening @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 4.5.5. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.5.4 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/home/user/Electrum-4.5.5/electrum/gui/qt/util.py", line 1429, in on_qt_callback_signal
return func(self, *args[1:])
^^^^^^^^^^^^^^^^^^^^^
File "/home/user/Electrum-4.5.5/electrum/gui/qt/channel_details.py", line 156, in on_event_htlc_failed
self.move('inflight', 'failed', payment_hash)
File "/home/user/Electrum-4.5.5/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: b'dg>\x98\xa76\x1b\xc9\xf8B\xa1\x1c\x98\xc0\xed\xee\x1a\xb0\xdd\x1c?v\x94\x9e\x0c|I\x80:\xebf>'
KeyError: b'dg>\x98\xa76\x1b\xc9\xf8B\xa1\x1c\x98\xc0\xed\xee\x1a\xb0\xdd\x1c?v\x94\x9e\x0c|I\x80:\xebf>'
~ With robotic wishes
Good morning @SomberNight,
I just received another crash report related to this issue. The crash occured on Electrum 29977a9. I'm not sure which versions of Electrum include the fix but this is the first report from anything newer than 4.5.5 since you closed the issue.
Could you please check if this issue really is resolved? Here is the traceback that I just collected:
Traceback (most recent call last):
File "/home/errge/work/multi-crypto/bin/btc-electrum/lib/python3.12/site-packages/electrum/gui/qt/util.py", line 1429, in on_qt_callback_signal
return func(self, *args[1:])
^^^^^^^^^^^^^^^^^^^^^
File "/home/errge/work/multi-crypto/bin/btc-electrum/lib/python3.12/site-packages/electrum/gui/qt/channel_details.py", line 149, in on_event_htlc_fulfilled
self.move('inflight', 'settled', payment_hash)
File "/home/errge/work/multi-crypto/bin/btc-electrum/lib/python3.12/site-packages/electrum/gui/qt/channel_details.py", line 126, in move
row_idx = self.keyname_rows[fro].pop(payment_hash)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: b'\x905\x064{\xc55\x0b\xabp\xde\x03|\x98\xd2?1\xfe\xf3\xc4cLC\xa6\\}\xb5\xbe\xbc%$\xdd'
KeyError: b'\x905\x064{\xc55\x0b\xabp\xde\x03|\x98\xd2?1\xfe\xf3\xc4cLC\xa6\\}\xb5\xbe\xbc%$\xdd'
~ With robotic wishes
Crash Report
This crash report was reported through the automatic crash reporting system 🤖
Traceback
Reporter
This issue was reported by 104 user(s):
Additional Information