search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.45k stars 3.09k forks source link

Child pays for parent: allow editing total fee rate #6163

Open leafcutterant opened 4 years ago

leafcutterant commented 4 years ago

The CPFP transaction flow only offers setting the Fee for child and using the slider. It lacks the granularity of setting sat/byte, which I argue would be very much welcome.

Scope: desktop

gits7r commented 4 years ago

I don't recall previous versions but this is currently fixed. The CPFP pop-up now allows you to set the fee for the child using the slider but you can override in the above text box, and you have a bottom indicator of fee rate in sat / byte. Also all 3 fee methods are available from the checklist.

This issue can be safely closed.

SomberNight commented 4 years ago

For the record, here is a current pic:

pic ![cpfp](https://user-images.githubusercontent.com/29142493/98056609-3ae4b100-1e38-11eb-8427-3d9e9bb938b8.PNG)

I believe the dialog has not changed since the issue was opened. I think OP is asking to be able to enter a sat/byte fee rate (as the current TextEdit is for entering an absolute fee).

Sort of related: https://github.com/spesmilo/electrum/issues/3470 As linked issue explains, if there is a chain of unconfirmed parents, many of the details shown in the dialog are flawed. I am wondering whether allowing to enter a sat/byte fee (for the parent+child package, as opposed to for the whole package which we don't have) would make things better or worse.