search

spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.39k stars 3.07k forks source link

Clarify Script types in wizard (more information, help text, bip39/hardware wallet) #6894

Open jingxi285 opened 3 years ago

jingxi285 commented 3 years ago

Electrum wizard asks to "Choose the type of addresses in your wallet" Could this be clarified with the number the addresses start with? That's the simple way we know addresses, by how they start. So that would be updating the strings? Can this be done?

"legacy (p2pkh) starts with 1" "p2sh-segwit (p2wpkh-p2sh) starts with 3" "native segwit (p2wpkh starts with bc1"

It's also a shame, if I choose bc1, but it turns out all my addresses were starting with 3, I can't go back... I need to create a wallet for each right type of address?

Would like to tick all three options!

SomberNight commented 3 years ago

It's also a shame, if I choose bc1, but it turns out all my addresses were starting with 3, I can't go back... I need to create a wallet for each right type of address? Would like to tick all three options!

Electrum currently does not support mixed script types in a single wallet. As an advanced option, we will probably support it in the future though (https://github.com/spesmilo/electrum/issues/6016). Whether we would allow selecting multiple types on this dialog is a different question though.

In any case, let's narrow the scope of this issue to the following:

Electrum wizard asks to "Choose the type of addresses in your wallet" Could this be clarified with the number the addresses start with? That's the simple way we know addresses, by how they start. So that would be updating the strings? Can this be done?

"legacy (p2pkh) starts with 1" "p2sh-segwit (p2wpkh-p2sh) starts with 3" "native segwit (p2wpkh starts with bc1"

Alternatively, there could be an info/help button somewhere; or there could be tooltips (but then it would be nice to give some visible hint that they are there).

ecdsa commented 3 years ago

No. This screen will be removed. I'm tired of users constantly asking for more "features". This is a clear case of "less is more".

jingxi285 commented 3 years ago

No. This screen will be removed.

What will it be replaced with? (#6016) ?

I'm tired of users constantly asking for more "features". This is a clear case of "less is more".

Well I only asked to clarify the address types strings. But yes let's remove that whole screen and just automatically support all address types :-)

SomberNight commented 3 years ago

@ecdsa this screen is for bip39 or hardware signers -- are you maybe thinking of the "create new electrum seed - select type" screen? or what do you have in mind?

ecdsa commented 3 years ago

oh indeed, sorry, I had the "select seed type" screen in mind

jingxi285 commented 3 years ago

Speaking frankly, why not simplify the text listing the address types? Most users don't need to know it's p2wpkh-p2sh etc, and users won't know or care that PKH means Public Key Hash, or that SH means Script Hash.

"Legacy - starts with 1" "Script Hash - starts with 3" "Native Segwit - starts with bc1"