spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.22k stars 3.02k forks source link

build: update bundled python version #9013

Closed SomberNight closed 2 months ago

SomberNight commented 2 months ago

see individual commit messages

gruve-p commented 1 month ago

@SomberNight This broke building on macos

42993 INFO: Converting EXE to target arch (x86_64)
44111 INFO: Removing signature(s) from EXE
45143 INFO: Appending PKG archive to EXE
45180 INFO: Fixing EXE headers for code signing
45207 INFO: Re-signing the EXE
45350 INFO: Building EXE from EXE-00.toc completed successfully.
45372 INFO: checking BUNDLE
45373 INFO: Building BUNDLE because BUNDLE-00.toc is non existent
45373 INFO: Building BUNDLE BUNDLE-00.toc
Removing Qt binaries: qtweb qt3d qtgame qtdesigner qtquick qtlocation qttest qtxml
Traceback (most recent call last):
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/bin/pyinstaller", line 8, in <module>
    sys.exit(_console_script_run())
             ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 228, in _console_script_run
    run()
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 212, in run
    run_build(pyi_config, spec_file, **vars(args))
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 69, in run_build
    PyInstaller.building.build_main.main(pyi_config, spec_file, **kwargs)
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/building/build_main.py", line 1186, in main
    build(specfile, distpath, workpath, clean_build)
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/building/build_main.py", line 1126, in build
    exec(code, spec_namespace)
  File "contrib/osx/osx.spec", line 98, in <module>
    app = BUNDLE(
          ^^^^^^^
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/building/osx.py", line 124, in __init__
    self.__postinit__()
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/building/datastruct.py", line 184, in __postinit__
    self.assemble()
  File "/Users/runner/work/electrum/electrum/contrib/osx/build-venv/lib/python3.11/site-packages/PyInstaller/building/osx.py", line 611, in assemble
    os.makedirs(dest_dir, exist_ok=True)
  File "<frozen os>", line 215, in makedirs
  File "<frozen os>", line 215, in makedirs
  File "<frozen os>", line 225, in makedirs
FileNotFoundError: [Errno 2] No such file or directory: '/Users/runner/work/electrum/electrum/dist/Electrum.app/Contents/Frameworks/electrum/plugins'

Could only find this issue for reference: https://github.com/pyinstaller/pyinstaller/issues/8363

SomberNight commented 1 month ago

Hmm, pretty sure I've tested not only building on macos, but reproducibility as well. But I will try to re-test then...

SomberNight commented 1 month ago

Tested again. Builds for me.

Perhaps you have something old cached. E.g. try again after $ git clean -ffxd