spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.22k stars 3.02k forks source link

qml: fix handling of channel backup import on lightning-disabled wallets #9091

Closed accumulator closed 2 weeks ago

accumulator commented 2 weeks ago

importing a channel backup to a second bip39/xprv wallet with lightning disabled now shows proper message instead of exception text.

We could also provide the option to the user here to enable lightning?

SomberNight commented 2 weeks ago

We could also provide the option to the user here to enable lightning?

To be clear, there is already an option in the wallet details to enable lightning, and you just mean we could also offer to enable it here, right? I have no strong opinion on that, but I think it's fine to keep it as-is.

accumulator commented 2 weeks ago

We could also provide the option to the user here to enable lightning?

To be clear, there is already an option in the wallet details to enable lightning, and you just mean we could also offer to enable it here, right?

Correct

I have no strong opinion on that, but I think it's fine to keep it as-is.

No strong opinion here either, just wanted to mention it.