spesmilo / electrum

Electrum Bitcoin Wallet
https://electrum.org
MIT License
7.38k stars 3.07k forks source link

Commas should be used instead of spaces as thousands separator #9102

Open paintballpanda opened 3 months ago

paintballpanda commented 3 months ago

Being a user in a country that uses commas as a thousands separator, the spaces being used is very confusing and looks as if there is a bug in the GUI. I actually just assumed it was a bug that had crept in and would be fixed in the next version but upon coming here to post the bug it looks like it was done intentionally.

Can we please have an option to remove the spaces, and use commas as thousands separators on the left side of the decimal, and no commas on the right side of the decimal? (Basically asking for an option for it to follow US locale settings).

Example: 1 BTC ~ $64,300.21 USD -or- Balance: 0.10400514 BTC (6,684.57 USD)

(note the commas separator left of the decimal, no separator on the right of the decimal)

From a UI/UX perspective, the spaces just make it look like its broken.

Thank you for your consideration.

Originally posted by @paintballpanda in https://github.com/spesmilo/electrum/issues/6423#issuecomment-2183973709

robbiehanson commented 3 weeks ago

https://bitcoin.design/guide/designing-products/units-and-symbols/#formatting-units