Internal server error on login/register

[inknos]

Steps to reproduce.

Login.

1. Build the container podman build -t songbook .
2. Run with podman run --rm -it --name songbook-test -e SECRET_KEY=aaabbbccc -p 8080:80 songbook:latest
3. Visit login page http://0.0.0.0:8080/login
4. Input email a@a.com and pass a

5. result

   INFO:     10.0.2.100:34900 - "POST /login HTTP/1.1" 500 Internal Server Error                                                                        
   ERROR:    Exception in ASGI application                                                                                                              
   Traceback (most recent call last):                                                                                                                   
   File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi                                           
   result = await app(  # type: ignore[func-returns-value]                                                                                          
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
   return await self.app(scope, receive, send)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                      
   File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 1106, in __call__
   await super().__call__(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
   await self.middleware_stack(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
   raise exc                                                                                                                                        
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
   await self.app(scope, receive, _send)                   
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/authentication.py", line 48, in __call__
   await self.app(scope, receive, send)              
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
   raise exc                                                                                                                                        
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
   await self.app(scope, receive, sender)                
   File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__         
   raise e            
   File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
   await self.app(scope, receive, send)                                                                                                             
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
   await route.handle(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
   await self.app(scope, receive, send)                                                                                                             
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
   response = await func(request)                                        
              ^^^^^^^^^^^^^^^^^^^                                        
   
   File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 274, in app
   raw_response = await run_endpoint_function(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 193, in run_endpoint_function
   return await run_in_threadpool(dependant.call, **values)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
   return await anyio.to_thread.run_sync(func, *args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/to_thread.py", line 33, in run_sync
   return await get_asynclib().run_sync_in_worker_thread(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
   return await future
          ^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 807, in run
   result = context.run(func, *args)
            ^^^^^^^^^^^^^^^^^^^^^^^^
   File "/code/app/main.py", line 100, in login_post_view
   data, errors = utils.valid_schema_data_or_error(raw_data, UserLoginSchema)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/code/app/utils.py", line 17, in valid_schema_data_or_error
   cleaned_data = SchemaModel(**raw_data)
                  ^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/pydantic/main.py", line 339, in __init__
   values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/pydantic/main.py", line 1102, in validate_model
   values = validator(cls_, values)
            ^^^^^^^^^^^^^^^^^^^^^^^
   File "/code/app/users/schemas.py", line 25, in validate_user
   user_obj = auth.authenticate(email, password)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/code/app/users/auth.py", line 20, in authenticate
   if not user_obj.verify_password(password):
          ^^^^^^^^^^^^^^^^^^^^^^^^
   AttributeError: 'NoneType' object has no attribute 'verify_password'

Register

Repeat steps 1,2

3. register email a@a.com with pass a
4. result

   INFO:     10.0.2.100:46416 - "GET /signup HTTP/1.1" 200 OK
   INFO:     10.0.2.100:58404 - "POST /signup HTTP/1.1" 500 Internal Server Error                             
   ERROR:    Exception in ASGI application
   Traceback (most recent call last):                                                                                                                   
   File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi
   result = await app(  # type: ignore[func-returns-value]                                                                                          
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
   return await self.app(scope, receive, send)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                      
   File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 1106, in __call__
   await super().__call__(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
   await self.middleware_stack(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
   raise exc                                                                                                                                        
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
   await self.app(scope, receive, _send)                   
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/authentication.py", line 48, in __call__
   await self.app(scope, receive, send)              
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
   raise exc                                                                                                                                        
   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
   await self.app(scope, receive, sender)                
   File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__         
   raise e            
   File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
   await self.app(scope, receive, send)                                                                                                             
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
   await route.handle(scope, receive, send)
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
   await self.app(scope, receive, send)                                
   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
   response = await func(request)                                        
              ^^^^^^^^^^^^^^^^^^^  
   File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 274, in app
   raw_response = await run_endpoint_function(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 193, in run_endpoint_function
   return await run_in_threadpool(dependant.call, **values)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
   return await anyio.to_thread.run_sync(func, *args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/to_thread.py", line 33, in run_sync
   return await get_asynclib().run_sync_in_worker_thread(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
   return await future
          ^^^^^^^^^^^^
   File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 807, in run
   result = context.run(func, *args) 
            ^^^^^^^^^^^^^^^^^^^^^^^^ 
   File "/code/app/main.py", line 128, in signup_post_view
   User.create_user(data["email"], data["password"].get_secret_value())
   File "/code/app/users/models.py", line 42, in create_user
   raise Exception(f"Invalid email: {msg}")
   Exception: Invalid email: The domain name a.com does not exist.

[spetrovi]

Awkay, I know what's going on. The signup doesn't work, because you're using invalid email domain, that's why: Exception: Invalid email: The domain name a.com does not exist.

The login doesn't work, because there's no user created.

I'll try to catch these exceptions and do a nice display

[spetrovi]

Alrigth, I resolved all the problems. All errors are now caught and displayed nicely as a bootstrap alert, feel free to try