search

spezifisch / stmps

Subsonic Terminal Music Player S
GNU General Public License v3.0
13 stars 6 forks source link

Clean up linting warnings #38

Open xxxserxxx opened 6 days ago

xxxserxxx commented 6 days ago

The build pipeline is issuing some linter warnings. These should be cleaned up.

This would be a good first issue.

spezifisch commented 4 days ago

For the record:

page_queue.go:182:19: Error return value of `q.ui.player.Stop` is not checked (errcheck)
        q.ui.player.Stop()
                        ^
page_queue.go:207:19: Error return value of `q.ui.player.Stop` is not checked (errcheck)
        q.ui.player.Stop()
                        ^
page_queue.go:226:18: Error return value of `q.ui.player.Stop` is not checked (errcheck)
    q.ui.player.Stop()
                    ^
page_search.go:253:3: SA4006: this value of `err` is never used (staticcheck)
        response, err = s.ui.connection.GetAlbum(album.Id)
xxxserxxx commented 3 days ago

@spezifisch do you know why the linter requires libglx and libgl? Are these dependencies of libmpv on Ubuntu? Seem like weird dependencies for a purely TUI application, so I'm assuming the connection is through libmpv.