search

spezifisch / stmps

Subsonic Terminal Music Player S
GNU General Public License v3.0
13 stars 6 forks source link

Makes 'a' in the browser tab consistent #41

Closed xxxserxxx closed 2 weeks ago

xxxserxxx commented 2 weeks ago

a in the entities column (albums or songs) advances the selection cursor to the next item. This tiny patch makes the action in the artists column behave the same way so the UX is consistent. Consistency is sufficient, IMO, but if for no other reason, it also provides feedback to the user that their button press did something.

xxxserxxx commented 2 weeks ago

sigh

I created a conflict for myself. In global-search I factored out the currentIndex variable that was used only once; with this patch, it's used twice and so needs to indeed be a declared variable. This will probably result in either a merge conflict, or a failure to compile, so if you merge global-search I'll update this patch to make it work with the other PR.

spezifisch commented 2 weeks ago

Thanks, I accidentally pushed the merge too early so I fixed the merge problem, too.