Closed xxxserxxx closed 1 month ago
I have a commit pending to display the DiscNumber in the song info, but as the PRs stack up I'm increasingly concerned about merge conflicts -- and especially here where I had to rename a variable that was renamed in a different branch. After these are merged, I'll create a separate PR for the song info change.
This is implemented as a side-bar column in the play queue:
Upsides:
text/template
(at the end ofpage_queue.go
). If it weren't for the fact that the Song entity is pretty anemic and doesn't capture all of the information the server provides, adding more data would be a mere matter of adding lines to the template. It'd be really easy to capture this extra metadata, but I wanted to keep this PR relatively constrained.The downside is that it takes up space.
I also considered just adding more columns to the queue; namely, the Album and Track. The pro of doing this is that it keeps the UI clean; the downside is that there's only so much information you can squish into that table without forcing the user to scroll around to see things.
I briefly considered implementing both and allowing the user to choose which with a flag, but that seems better left to a different PR.
It might be useful to add a hotkey to allow the user to hide the metadata column; I understand how to hide pages in
tview
, but figuring out how to hide elements would -- while not necessarily hard -- have required significantly more time on my end in self-education.I'm sending this as you've included this item in milestone #1. I'm going to add a ticket to capture more of the song metadata the servers are providing and add them to the template; another one for displaying cover art; and another for hotkey hiding/showing the metadata column.