search

spezifisch / stmps

Subsonic Terminal Music Player S
GNU General Public License v3.0
19 stars 6 forks source link

Feat 67 hide song panel #78

Closed xxxserxxx closed 1 month ago

xxxserxxx commented 1 month ago

Because of all the dependent changes, this is branched off concurrent-album-art.

This allows users to disable the song info pane by setting:

[ui]
hide-info-pane = true

While the pane can't be dynamically hidden, this code does completely disable the creation of resources needed to display the pane, image art, caching, and all of that overhead. I think this is sufficient to close #67

spezifisch commented 1 month ago

Let's see how the changelog cmd handles a squash merge.

spezifisch commented 1 month ago

Because of all the dependent changes, this is branched off concurrent-album-art.

And... I forgot you wrote that, oops. I think you should have sufficient privileges to merge into everything except the main branch. Or did you explicitly want me to review this (Edit: I did; I like it)?

xxxserxxx commented 1 month ago

I kept it separate because it was a separate feature, and isn't strictly necessary. It's possible you would decline it; if I merged it into concurrent-album-art, then there'd be a lot more work if you rejected it.

I'm still erring on leaving you options, although it does make more work for you. I can just merge things like this together, if you prefer.