search

spf13 / afero

A FileSystem Abstraction System for Go
Apache License 2.0
5.8k stars 498 forks source link

rename mem fs with descendants #364

Closed hanagantig closed 9 months ago

hanagantig commented 2 years ago

fix for issue #141 Please check it. This bug needs to be fixed.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

hanagantig commented 1 year ago

@bep hi, this is an old pull request for https://github.com/spf13/afero/issues/141 issue. I updated the branch and resolved conflicts. If you have time could you look at it please, it would be appreciated.

hanagantig commented 10 months ago

@bep any comments or suggestions here please

bep commented 10 months ago

@hanagantig sorry for the delay; this looks correct, but it needs to be rebased with master. If you do that and ping me again, I will merge.

hanagantig commented 10 months ago

@bep Thanks a lot. I just pushed it without merge commits. Could you please have a look?

bep commented 10 months ago

@hanagantig there's a staticcheck error there that should be easy to fix.

hanagantig commented 10 months ago

@bep unnecessary assignment static check error fixed

hanagantig commented 10 months ago

@bep can we merge it please ?

hanagantig commented 9 months ago

@bep your attention is required. Could you please proceed with checks ?

hanagantig commented 9 months ago

@bep thank you so much :pray: