spf13 / viper

Go configuration with fangs
MIT License
26.33k stars 2.01k forks source link

EOL before EOF #1330

Open chapterjason opened 2 years ago

chapterjason commented 2 years ago

Preflight Checklist

Problem Description

I use viper to write a config file in an init command, to add an initial configuration in the project. I noticed that viper writes the config without a newline (EOL) at the end of the file (EOF).

As I open the file with vim or other editors an EOL is added automatically to the EOF. This added EOL always ends up in a change in git.

Proposed Solution

Add a EOL before the EOF on writing the config. To avoid changes in the behavior for others this behavior should be opt-in.

Alternatives Considered

No response

Additional Information

No response

github-actions[bot] commented 2 years ago

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️