API to stop the file watcher

skidder commented 2 years ago

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

I'd like to be able to stop the file watcher created by calling Viper.WatchFile(). Being able to gracefully tear down the filewatcher helps to ensure a clean shutdown without possible invocations of the onConfigChange function.

Proposed Solution

Add a Golang context and cancel-function to the Viper struct type. Move the events waitgroup (eventsWG) from the watcher go-routine to the Viper struct type. Initialize these fields in the WatchConfig() function. Add a Viper.Stop() function that calls the cancel function to stop the watcher.

Alternatives Considered

No response

Additional Information

No response

github-actions[bot] commented 2 years ago

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

lvyonghuan commented 4 weeks ago

I think this feature should be there, it has its uses

spf13 / viper