Closed sagikazarmark closed 12 months ago
👋 Thanks for contributing to Viper! You are awesome! 🎉
A maintainer will take a look at your pull request shortly. 👀
In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.
⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9
📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:
https://twitter.com/sagikazarmark/status/1306904078967074816
Thank you! ❤️
This PR adds
log/slog
support the following way:log/slog
as usualUnder the hood, Viper uses github.com/sagikazarmark/slog-shim to provide support slog on Go 1.20 and below.
At the same time, this PR breaks backwards compatibility with github.com/spf13/jwalterweatherman. Enabling logging through jww no longer works after this change, but since there are no compile errors the only result is no logs being output.
Enabling logging is possible by using the new
WithLogger
option:Further changes:
Trace
level logs are now logged asDebug
WithLogger
option is changed to accept an*slog.Logger
and is now publicly availableLogger
interface is deprecated and no longer in use (will be removed in a later release)Fixes #1270 Fixes #1372