search

spf13 / viper

Go configuration with fangs
MIT License
26.77k stars 2.01k forks source link

feat: reading remote configuration should not merge kvstore #1633

Open acynothia opened 12 months ago

acynothia commented 12 months ago

The behavior of ReadRemoteConfig may should be consistent with ReadInConfig. If merging functionality is required, perhaps introducing an additional function MergeRemoteConfig might be a better choice. This change prevents the scenario where deleted keys in the remote configuration can still be retrieved via ReadRemoteConfig. Unfortunately, This is a breaking behavior change.

github-actions[bot] commented 12 months ago

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️