spf13 / viper

Go configuration with fangs
MIT License
27.01k stars 2.01k forks source link

ci: enable test shuffle and fix tests #1643

Closed alexandear closed 10 months ago

alexandear commented 1 year ago

This PR extends go test with -shuffle flag:

-shuffle off,on,N
    Randomize the execution order of tests and benchmarks.
    It is off by default. If -shuffle is set to on, then it will seed
    the randomizer using the system clock. If -shuffle is set to an
    integer N, then N will be used as the seed value. In both cases,
    the seed will be reported for reproducibility.

Also, fix conflicting tests.

github-actions[bot] commented 1 year ago

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

sagikazarmark commented 1 year ago

Sounds like a good idea, but looks like the tests are failing. :/

alexandear commented 1 year ago

@sagikazarmark the tests are failing because they depend on each other. I'll try to fix it in this PR.

alexandear commented 1 year ago

@sagikazarmark fixed tests