spf13 / viper

Go configuration with fangs
MIT License
26.47k stars 2.01k forks source link

Support for custom pflags #1677

Open unguiculus opened 8 months ago

unguiculus commented 8 months ago

Preflight Checklist

Problem Description

It is possible to create custom pflags by implementing the Value interface. The problem is that viper just calls ValueString() on value types it doesn't know about.

I implemented a custom StringToBool flag, which pflags unfortunately lacks. In order for this to work properly, I would need Viper to call a conversion function as is, e.g., done for stringToInt.

Proposed Solution

My suggestion would be to add an option to register custom conversion functions for value types.

func (v *Viper) RegisterValueTypeConvFunc(valueType string, confFunc func(val string) any)

If a function is registered for a value type, Viper would then call this function in the find method.

I would offer to work on this if there is interest.

Alternatives Considered

No response

Additional Information

No response

github-actions[bot] commented 8 months ago

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️