search

spf13 / viper

Go configuration with fangs
MIT License
26.47k stars 2.01k forks source link

Merge missing struct keys inside UnmarshalExact #1704

Closed krakowski closed 7 months ago

krakowski commented 7 months ago

This is a follow-up PR after #1429. A comment mentioned UnmarshalExact not working as intended. Looking into the code I found that the list of struct keys was not merged with AllKeys inside UnmarshalExact, leading to the mentioned error.

This PR fixes this by performing the same steps in UnmarshalExact.

@sagikazarmark

github-actions[bot] commented 7 months ago

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

sagikazarmark commented 7 months ago

Thanks @krakowski

sagikazarmark commented 7 months ago

Released as https://github.com/spf13/viper/releases/tag/v1.18.1