Enable experimental features runtime

sagikazarmark commented 9 months ago

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Consumers may want to enable experimental features runtime. Although it may not always be possible, it should be doable for the most part.

Proposed Solution

Introduce a new API to enable feature flags in Viper.

Something like:

v := viper.New(viper.Enable("bind-struct"))

The nice thing about this API is that it's generic and it doesn't necessarily break once an experiment is rolled out as a fully functional feature.

The counterpart of Enable should be Disable, so users can go back to the old behavior while it's still available.

Alternatives Considered

Other potential names:

EnableFlag/DisableFlag
EnableExperiment/DisableExperiment
Enable(Experimental)Feature/Disable(Experimental)Feature

Additional Information

Came up in https://github.com/spf13/viper/issues/1706#issuecomment-1858515373

github-actions[bot] commented 9 months ago

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

mazenharake commented 6 months ago

imho, I think I would prefer viper.New(viper.EnableBindStruct(), ...). I would also reckon it is easier to maintain since as more features are released then the viper.Enable("...") could become bloated. Since this is going to become a part of the API then it is clearer to know what Options there are by simply looking at the exported Options rather than to look up a string in the documentation.

just my 2 cents, either would be fine though.

spf13 / viper