search

spf13 / viper

Go configuration with fangs
MIT License
26.32k stars 2.01k forks source link

Fix #1732 AutomaticEnv does not override Unmarshaled config slice values #1733

Open lwlee2608 opened 6 months ago

lwlee2608 commented 6 months ago

fix #1732

I have spent quite a lot of time trying to solve this. The difficulty lies in not knowing how many elements a slice config contains. The only option I see is to apply the automatic env override again after we find a key, since only then would we have retrieved all the slice fields, making it possible to check if the env for an individual slice element exists for overriding.

Please let me know if my changes are acceptable. I am happy to hear your feedback.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 6 months ago

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️